Jetty
  1. Jetty
  2. JETTY-776

Make new jetty-session-tests module to concentrate all reusable session clustering test code

    Details

    • Type: Task Task
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Servlet
    • Labels:
      None
    • Number of attachments :
      0

      Description

      There are many standard and repeatable tests that we want to be able to apply to the various jetty session clustering implementations which to date include terracotta, openspaces and jdbc. These tests are presently in the jetty module and built into a test artifact, which only gets built as I discovered, if you execute the tests as part of the install goal. The terracotta session implementation does not presently use these tests, but has another set of its own.

      We need to make a new jetty-session-tests module and move all of the reusable test code into it. As the terracotta session test design is simpler to understand, we should base this new module on that code, and refactor it to make the session implementation pluggable. We should also add any tests that are necessary to ensure that we have as good or better test coverage than we had with the tests in AbstractSessionTest in the jetty module.

      Then, all of the clustered session implementations must be made to depend on the jetty-session-tests artifact.

      One difficulty is that the JDBCSessionManager implementation in the jetty module would need to depend on the jetty-session-tests artifact, which itself will have explicit and transitive dependencies on the jetty module, thus creating circular dependencies.

        Activity

        Hide
        Jan Bartel added a comment -

        Changes to genericize the session tests are checked into jetty-7 trunk. The jetty-terracotta module in jetty-codehaus remains to be converted.

        Show
        Jan Bartel added a comment - Changes to genericize the session tests are checked into jetty-7 trunk. The jetty-terracotta module in jetty-codehaus remains to be converted.
        Hide
        Jan Bartel added a comment -

        The jetty-terracotta module has been converted.

        The gigaspaces modules has not yet been converted, but that cannot be done until the gigaspaces session clustering solution has been ported from jetty-6 to jetty-7.

        Show
        Jan Bartel added a comment - The jetty-terracotta module has been converted. The gigaspaces modules has not yet been converted, but that cannot be done until the gigaspaces session clustering solution has been ported from jetty-6 to jetty-7.
        Hide
        Jan Bartel added a comment -

        Downgrading this to "minor" priority, as there is only one module left to port, which itself requires some work in any case.

        Show
        Jan Bartel added a comment - Downgrading this to "minor" priority, as there is only one module left to port, which itself requires some work in any case.
        Hide
        Jan Bartel added a comment -

        Closing this issue as all relevant session impls have been moved into the appropriate session test module.

        Show
        Jan Bartel added a comment - Closing this issue as all relevant session impls have been moved into the appropriate session test module.

          People

          • Assignee:
            Jan Bartel
            Reporter:
            Jan Bartel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: