Jetty

byte to int conversion error in HttpConnection.Input.read()

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.0.0beta8
  • Fix Version/s: 6.0.0beta10
  • Component/s: HTTP
  • Labels:
    None
  • Number of attachments :
    1

Description

In HttpConnection.Input.read(), the single byte read from the Buffer is simply returned as an int.
Unfortunately, bytes are signed in java, but the int result of InputStream.read is expected to be >= 0 if a byte could be read and -1 if it could not be read.
This lets any servlet reading a single byte assume EOF if any byte > 0x7f is read.

The following patch fixes it.

Index: modules/jetty/src/main/java/org/mortbay/jetty/HttpConnection.java
===================================================================
— modules/jetty/src/main/java/org/mortbay/jetty/HttpConnection.java (revision 200)
+++ modules/jetty/src/main/java/org/mortbay/jetty/HttpConnection.java (working copy)
@@ -717,7 +717,7 @@

{ int c=-1; if (blockForContent()) - c= _content.get(); + c= (256 + _content.get()) % 256; return c; }

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Yug added a comment -

The patch

Show
Yug added a comment - The patch
Hide
Permalink
Greg Wilkins added a comment -

Fixed, but with c= 0xff&_content.get()

Show
Greg Wilkins added a comment - Fixed, but with c= 0xff&_content.get()

People

  • Assignee:
    Greg Wilkins
    Reporter:
    Yug
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: