Jetty

Implement scanning for TLD, annotations and web.xml fragments

Details

  • Type: Sub-task Sub-task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 7.0.0pre1
  • Fix Version/s: 8.0.0.M1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. JETTY-611 Provide general-purpose mechanism to control scanning of jars in jetty/lib and WEB-INF/lib for tlds, annotation, web.xml fragments

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jan Bartel added a comment -

TLD and web fragment scanning is complete, annotations remain to be done.

Show
Jan Bartel added a comment - TLD and web fragment scanning is complete, annotations remain to be done.
Hide
Permalink
Jan Bartel added a comment -

Annotation processing has been re-implemented using asm to parse source of classes. This prepares for new annotation processing for servlet3.0. See rev 3277.

Show
Jan Bartel added a comment - Annotation processing has been re-implemented using asm to parse source of classes. This prepares for new annotation processing for servlet3.0. See rev 3277.
Hide
Permalink
Jan Bartel added a comment -

I think svn rev 3353 is feature complete as far as the annotation processing is concerned. The jetty-annotation-test-webapp has been updated with an annotated pojo as an example. More testing needs to be done, and an example pojo for Filter and Listener types needs to be added.

As the annotations themselves are not yet available from the JSR, I've checked them in temporarily to https://svn.codehaus.org/jetty/servlet-annotation-spec. This can be removed and the dependencies in modules/plus changed once they are final and available.

Show
Jan Bartel added a comment - I think svn rev 3353 is feature complete as far as the annotation processing is concerned. The jetty-annotation-test-webapp has been updated with an annotated pojo as an example. More testing needs to be done, and an example pojo for Filter and Listener types needs to be added. As the annotations themselves are not yet available from the JSR, I've checked them in temporarily to https://svn.codehaus.org/jetty/servlet-annotation-spec . This can be removed and the dependencies in modules/plus changed once they are final and available.
Hide
Permalink
Jan Bartel added a comment -

All annotations are implemented as of 8.0.0.M1. Using the org.mortbay.servlet 3 api jar as there is no javax.servlet 3 api jar in the maven repo, and the maven rules now say you cannot reference a repository in a released pom so we cannot use the ones that Sun have released over at dev.java.net.

Show
Jan Bartel added a comment - All annotations are implemented as of 8.0.0.M1. Using the org.mortbay.servlet 3 api jar as there is no javax.servlet 3 api jar in the maven repo, and the maven rules now say you cannot reference a repository in a released pom so we cannot use the ones that Sun have released over at dev.java.net.
Hide
Permalink
paulo silveira added a comment -

Jan, I am using 8.00M1 and I cant make the scanning work for @WebServlet classes. I need to use @org.mortbay.servlet.WebServlet instead od the javax one?

Show
paulo silveira added a comment - Jan, I am using 8.00M1 and I cant make the scanning work for @WebServlet classes. I need to use @org.mortbay.servlet.WebServlet instead od the javax one?
Hide
Permalink
Jan Bartel added a comment -

Paulo,

No, you don't need to use anything special. I suspect you're using the eclipse release of jetty, which does not have annotations enabled by default. Have a look at the start.ini file and the etc/jetty-plus.xml file. Alternatively, it may be easier to use the hightide distribution of jetty which has annotations enabled by default: http://dist.codehaus.org/jetty/jetty-hightide-8.0.0.M1/

Show
Jan Bartel added a comment - Paulo, No, you don't need to use anything special. I suspect you're using the eclipse release of jetty, which does not have annotations enabled by default. Have a look at the start.ini file and the etc/jetty-plus.xml file. Alternatively, it may be easier to use the hightide distribution of jetty which has annotations enabled by default: http://dist.codehaus.org/jetty/jetty-hightide-8.0.0.M1/
Hide
Permalink
paulo silveira added a comment -

Thanks Jan! I am using it as a dependency for maven/gradle (org.eclipse.jetty:jetty-distribution:8.0.0.M1). Is there a maven repo for hightide?

Enabling jetty-plus.xml inside start.ini and configuring its monitoredDir did not solve the problem (if I configure the servlet inside web.xml, it works, but I would like to use the autodiscovery)

Show
paulo silveira added a comment - Thanks Jan! I am using it as a dependency for maven/gradle (org.eclipse.jetty:jetty-distribution:8.0.0.M1). Is there a maven repo for hightide? Enabling jetty-plus.xml inside start.ini and configuring its monitoredDir did not solve the problem (if I configure the servlet inside web.xml, it works, but I would like to use the autodiscovery)
Hide
Permalink
Jan Bartel added a comment -

Paulo,
You need to add a few more OPTIONS as well eg annotations, plus. Re hightide: its in the standard maven repo: http://repo1.maven.org/maven2/org/mortbay/jetty/jetty-hightide/8.0.0.M1/

Show
Jan Bartel added a comment - Paulo, You need to add a few more OPTIONS as well eg annotations, plus. Re hightide: its in the standard maven repo: http://repo1.maven.org/maven2/org/mortbay/jetty/jetty-hightide/8.0.0.M1/
Hide
Permalink
paulo silveira added a comment -

Thanks again Jan.

Now, using hightide 80M1 and making OPTIONS=All seams to be not enough (even putting jetty-highrise in start.ini). Everything works fine but the autodetection.

Show
paulo silveira added a comment - Thanks again Jan. Now, using hightide 80M1 and making OPTIONS=All seams to be not enough (even putting jetty-highrise in start.ini). Everything works fine but the autodetection.
Hide
Permalink
Jan Bartel added a comment -

Paulo,

Can you open a thread on the jetty list for this discussion?
thanks
Jan

Show
Jan Bartel added a comment - Paulo, Can you open a thread on the jetty list for this discussion? thanks Jan

People

  • Assignee:
    Jan Bartel
    Reporter:
    Greg Wilkins
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: