[#JETTY-574] SLF4J classes not visible when added as dependencies to maven-jetty-plugin - jira.codehaus.org

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Not A Bug
Affects Version/s: 6.1.7, 6.1.8, 6.1.9, 7.0.0pre0, 7.0.0pre1
Fix Version/s: 6.1.7
Component/s: Maven
Labels:
None

Number of attachments :
1

Description

Adding SLF4J as a dependency to maven-jetty-plugin doesn't make it visible to the running webapp (NoClassDefFoundError: org/slf4j/impl/StaticLoggerBinder)
It works fine with other libraries than SLF4J.

Try mvn jetty:run with the attached project.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

$i18n.getText("admin.common.words.hide")
test-slf4j.zip

14/May/08 8:41 AM

3 kB

Martin Strand
pom.xml 2 kB

src/main/java/test/Test.java 0.8 kB

src/main/resources/log4j.xml 0.5 kB

src/main/webapp/WEB-INF/web.xml 0.5 kB

Download Zip
$i18n.getText("admin.common.words.show")

test-slf4j.zip

14/May/08 8:41 AM

3 kB

Martin Strand

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Martin Strand added a comment - 14/May/08 8:44 AM

Oops, I mean the error is "NoClassDefFoundError: org/slf4j/LoggerFactory" since it's slf4j-api that isn't visible.

Show

Martin Strand added a comment - 14/May/08 8:44 AM Oops, I mean the error is "NoClassDefFoundError: org/slf4j/LoggerFactory" since it's slf4j-api that isn't visible.

Hide

Permalink

Igor E. Poteryaev added a comment - 14/May/08 9:14 AM

According to Jetty classloading architecture (see http://docs.codehaus.org/display/JETTY/Classloading),
org.slf4j.* classes by default are included in so called ServerClasses and are hidden from webapp context classloaders.

I think that you have two possibilities:

1. Override default ServerClasses list excluding org.slf4j. from it. After it webapp context classloader will see slf4j classes from parent classloader.

2. Add slf4j dependencies not only to maven-plugin-jetty, but as dependency at top maven pom <dependencies> level . After it webapp context classloader will see slf4j classes from its own WEB-INF/lib/ directory.

Show

Igor E. Poteryaev added a comment - 14/May/08 9:14 AM According to Jetty classloading architecture (see http://docs.codehaus.org/display/JETTY/Classloading), org.slf4j.* classes by default are included in so called ServerClasses and are hidden from webapp context classloaders. I think that you have two possibilities: 1. Override default ServerClasses list excluding org.slf4j. from it. After it webapp context classloader will see slf4j classes from parent classloader. or 2. Add slf4j dependencies not only to maven-plugin-jetty, but as dependency at top maven pom <dependencies> level . After it webapp context classloader will see slf4j classes from its own WEB-INF/lib/ directory.

Hide

Permalink

Martin Strand added a comment - 14/May/08 11:07 AM

Sorry for the false alarm, I didn't know Jetty was hiding certain classes.
Your first suggestion works great, I added this to the plugin configuration and now everything's ok:

<configuration>
<webAppConfig>
<contextPath>/test</contextPath>
<serverClasses>
<filter>-org.mortbay.jetty.plus.jaas.</filter>
<filter>org.mortbay.jetty.</filter>
</serverClasses>
</webAppConfig>
</configuration>

Thanks!

Show

Martin Strand added a comment - 14/May/08 11:07 AM Sorry for the false alarm, I didn't know Jetty was hiding certain classes. Your first suggestion works great, I added this to the plugin configuration and now everything's ok: <configuration> <webAppConfig> <contextPath>/test</contextPath> <serverClasses> <filter>-org.mortbay.jetty.plus.jaas.</filter> <filter>org.mortbay.jetty.</filter> </serverClasses> </webAppConfig> </configuration> Thanks!

Hide

Permalink

Ken Dobson added a comment - 22/Mar/09 2:02 PM

Martin's comment was very helpful to me, but I found that further configuration is required if using jcl-over-slf4j because Jetty exposes the standard Commons Logging API to applications.

Revised configuration:

<webAppConfig>
<contextPath>/test</contextPath>
<serverClasses>

<filter>-org.mortbay.jetty.plus.jaas.</filter>
<filter>org.mortbay.jetty.</filter>
</serverClasses>
<systemClasses>

<filter>java.</filter>
<filter>javax.servlet</filter>
<filter>javax.xml.</filter>
<filter>org.mortbay.</filter>
<filter>org.xml.</filter>
<filter>org.w3c.</filter>
</systemClasses>
</webAppConfig>

Apologies for bumping an old, closed bug, but I found this bug when Googling for the problem, and expect this information may be useful to others.

Show

Ken Dobson added a comment - 22/Mar/09 2:02 PM Martin's comment was very helpful to me, but I found that further configuration is required if using jcl-over-slf4j because Jetty exposes the standard Commons Logging API to applications. Revised configuration: <webAppConfig> <contextPath>/test</contextPath> <serverClasses>  <filter>-org.mortbay.jetty.plus.jaas.</filter> <filter>org.mortbay.jetty.</filter> </serverClasses> <systemClasses>  <filter>java.</filter> <filter>javax.servlet</filter> <filter>javax.xml.</filter> <filter>org.mortbay.</filter> <filter>org.xml.</filter> <filter>org.w3c.</filter> </systemClasses> </webAppConfig> Apologies for bumping an old, closed bug, but I found this bug when Googling for the problem, and expect this information may be useful to others.

Hide

Permalink

Fabio Marinelli added a comment - 01/Jul/09 3:07 AM

In reply to Ken comment, there's a missing dot on javax.servlet

This is the working configuration.

<webAppConfig>
<contextPath>/test</contextPath>
<serverClasses>

<filter>-org.mortbay.jetty.plus.jaas.</filter>
<filter>org.mortbay.jetty.</filter>
</serverClasses>
<systemClasses>

<filter>java.</filter>
<filter>javax.servlet.</filter>
<filter>javax.xml.</filter>
<filter>org.mortbay.</filter>
<filter>org.xml.</filter>
<filter>org.w3c.</filter>
</systemClasses>
</webAppConfig>

Bye and sorry for posting again on this issue.

Show

Fabio Marinelli added a comment - 01/Jul/09 3:07 AM In reply to Ken comment, there's a missing dot on javax.servlet This is the working configuration. <webAppConfig> <contextPath>/test</contextPath> <serverClasses>  <filter>-org.mortbay.jetty.plus.jaas.</filter> <filter>org.mortbay.jetty.</filter> </serverClasses> <systemClasses>  <filter>java.</filter> <filter>javax.servlet.</filter> <filter>javax.xml.</filter> <filter>org.mortbay.</filter> <filter>org.xml.</filter> <filter>org.w3c.</filter> </systemClasses> </webAppConfig> Bye and sorry for posting again on this issue.

People

Assignee:

Unassigned

Reporter:

Martin Strand

Vote (0)

Watch (0)

Dates

Created:

14/May/08 8:41 AM

Updated:

01/Jul/09 3:07 AM

Resolved:

14/May/08 11:08 AM