Jetty

SelectChannelConnector throws Exception on close on Windows

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.9
  • Fix Version/s: 7.0.0pre3
  • Component/s: HTTP
  • Labels:
    None
  • Number of attachments :
    1

Description

Using jetty 6.1.9 on windows, when stopping jetty with cntrl-c, an exception is thrown from inside the nio llbrary.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jan Bartel added a comment -

Exception is ClosedChannelException. Full stack trace not yet available.

Show
Jan Bartel added a comment - Exception is ClosedChannelException. Full stack trace not yet available.
Hide
Permalink
David Yu added a comment -

Patched attached. Its basically the same shutdown sequence on SelectChannelConnector.
Resolves the ClosedChannelException on windows.

Show
David Yu added a comment - Patched attached. Its basically the same shutdown sequence on SelectChannelConnector. Resolves the ClosedChannelException on windows.
Hide
Permalink
Jan Bartel added a comment -

Hi David,

Thanks for the patch, but can you explain a little more how this this solves it? Moving the manager.close() from the SelectChannelConnector.doStop() method to the SelectChannelConnector.close() method seems to be equivalent to me as super.doStop() calls close() as the first action. Maybe I just haven't had enough coffee yet to appreciate the difference

cheers
Jan

Show
Jan Bartel added a comment - Hi David, Thanks for the patch, but can you explain a little more how this this solves it? Moving the manager.close() from the SelectChannelConnector.doStop() method to the SelectChannelConnector.close() method seems to be equivalent to me as super.doStop() calls close() as the first action. Maybe I just haven't had enough coffee yet to appreciate the difference cheers Jan
Hide
Permalink
David Yu added a comment -

Jan,

It was moved since manager.close() doesn't get called when jetty closes the connector.
It only gets called when the connector is stopped. (By this time, the exception is already thrown because of this race condition on windows)
This is the case when graceful shutdown is turned on.

Cheers,
David

Show
David Yu added a comment - Jan, It was moved since manager.close() doesn't get called when jetty closes the connector. It only gets called when the connector is stopped. (By this time, the exception is already thrown because of this race condition on windows) This is the case when graceful shutdown is turned on. Cheers, David
Hide
Permalink
David Yu added a comment -

patch applied in trunk

Show
David Yu added a comment - patch applied in trunk
Hide
Permalink
Jan Bartel added a comment -

Patch also applied in jetty-6.1 branch as rev 3106.

Show
Jan Bartel added a comment - Patch also applied in jetty-6.1 branch as rev 3106.

People

  • Assignee:
    David Yu
    Reporter:
    Jan Bartel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: