Jetty

Posted parameter values encoded in non utf-8 encoding are decoded incorrectly.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 6.1.6rc1, 6.1.6
  • Fix Version/s: 6.2.0pre0, 6.1.8
  • Component/s: HTTP
  • Labels:
    None
  • Environment:
    Mac OS X 10.4.11, JDK1.5.0_13
  • Number of attachments :
    2

Description

If a form value is encoded in some non-utf8 encoding (e.g. Shift_JIS), request.getParameter() returns an invalid string even if I call request.setCharacterEncoding() beforehand.
This worked fine with jetty 6.1.6rc0 and was broken in 6.1.6rc1.

It seems that the fix for #JETTY-388 caused the problem.
Please check the method UrlEncoded#decodeTo(InputStream in, MultiMap map, String charset, int maxLength).

–
I have attached a simple webapp to reproduce the problem.
If you need more information, please let me know.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. JETTY-501 /org/mortbay/util/UrlEncoded.java (method public static void decodeTo(InputStream in, MultiMap map, String charset, int maxLength)) - not valid use charset

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brynjar Glesnes added a comment -

This is a problem using 6.1.7 as well

Show
Brynjar Glesnes added a comment - This is a problem using 6.1.7 as well
Hide
Permalink
Jan Bartel added a comment -

I've tried out the test webapp both with jetty-6.1.7 and with 6.1 head, and it seems to decode the characters ok. I've tested with the usual A-Za-z0-9 chars as well as some european chars like Å and Ø. The test class seems to print out the chars submitted by the form, and ØØ for example printed out ØØ Is that not what you would expect? I'm happy to investigate further, but need to know what chars to enter to trigger the failure and what the expected failure is?

cheers
Jan

Show
Jan Bartel added a comment - I've tried out the test webapp both with jetty-6.1.7 and with 6.1 head, and it seems to decode the characters ok. I've tested with the usual A-Za-z0-9 chars as well as some european chars like Å and Ø. The test class seems to print out the chars submitted by the form, and ØØ for example printed out ØØ Is that not what you would expect? I'm happy to investigate further, but need to know what chars to enter to trigger the failure and what the expected failure is? cheers Jan
Hide
Permalink
Iwao AVE! added a comment -

A Japanese Hiragana '\u3042' for example.

–
But it would be better to have a test case for this

I have attached a modified version of the unit test ($

{JETTY_HOME}

/modules/util/src/test/java/org/mortbay/util/URLEncodedTest.java).

It fails against 6.1.7 while it passes against 6.1.6rc0.
You might need to enable "Support for additional locales" feature of your JRE if you get UnsupportedEncodingException.

Show
Iwao AVE! added a comment - A Japanese Hiragana '\u3042' for example. – But it would be better to have a test case for this I have attached a modified version of the unit test ($ {JETTY_HOME} /modules/util/src/test/java/org/mortbay/util/URLEncodedTest.java). It fails against 6.1.7 while it passes against 6.1.6rc0. You might need to enable "Support for additional locales" feature of your JRE if you get UnsupportedEncodingException.
Hide
Permalink
Jan Bartel added a comment -

Thanks for the test case. I've run this against jetty head, and it passes with no problems. Can you try with jetty-6.2-SNAPSHOT and see if it works for you?

cheers
Jan

Show
Jan Bartel added a comment - Thanks for the test case. I've run this against jetty head, and it passes with no problems. Can you try with jetty-6.2-SNAPSHOT and see if it works for you? cheers Jan
Hide
Permalink
Jan Bartel added a comment -

Checked in the provided test case to jetty head and jetty-6.1 branch.

This bug was actually fixed by gregw, but the jira was not updated.

Show
Jan Bartel added a comment - Checked in the provided test case to jetty head and jetty-6.1 branch. This bug was actually fixed by gregw, but the jira was not updated.
Hide
Permalink
Iwao AVE! added a comment -

Jan,

I have just realized that, too.
Thanks for your time anyway.

// Iwao

Show
Iwao AVE! added a comment - Jan, I have just realized that, too. Thanks for your time anyway. // Iwao
Hide
Permalink
Jan Bartel added a comment -

Bug fixed and test case checked in.

Show
Jan Bartel added a comment - Bug fixed and test case checked in.

People

  • Assignee:
    Jan Bartel
    Reporter:
    Iwao AVE!
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: