Jetty
  1. Jetty
  2. JETTY-502

<jsp:include..> - behaviour change

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 6.1.9
    • Fix Version/s: 7.0.0pre3, 6.1.12rc1
    • Component/s: JSP
    • Labels:
      None
    • Environment:
      Windows XP / 2003
    • Number of attachments :
      4

      Description

      From my index.jsp:

      <jsp:include page="Home.do"/>

      works on jetty6.1.4, but since 6.1.5 additional attribute "flush=true" was needed:

      <jsp:include page="Home.do" flush="true"/>

      Is there any reason for that behaviour ?!

      1. dispatcher6.diff
        16 kB
        Athena Yao
      2. dispatcher-7.diff
        16 kB
        Athena Yao
      3. ServletHandler.diff
        1 kB
        Athena Yao

        Activity

        Hide
        Athena Yao added a comment -

        Attached is a diff that takes the second approach I mentioned in my comment. This should fix the problem that I noticed while running the test case that Jose provided. I didn't go with setting the include servlet path to null, because that could possibly affect behavior of more things, in more subtle ways.

        Jose, I did not notice any difference between setting flush="true" and not setting flush="true", at least not with index.jsp/Home.do in the test project. It is possible that the problem/fix I dug out is different from the one that you were experiencing.

        Show
        Athena Yao added a comment - Attached is a diff that takes the second approach I mentioned in my comment. This should fix the problem that I noticed while running the test case that Jose provided. I didn't go with setting the include servlet path to null, because that could possibly affect behavior of more things, in more subtle ways. Jose, I did not notice any difference between setting flush="true" and not setting flush="true", at least not with index.jsp/Home.do in the test project. It is possible that the problem/fix I dug out is different from the one that you were experiencing.
        Hide
        Greg Wilkins added a comment -

        Jan,

        can you check what athena has found out on this one.

        Show
        Greg Wilkins added a comment - Jan, can you check what athena has found out on this one.
        Hide
        Jan Bartel added a comment -

        Athena,

        Can you make a simple test webapp to verify the behaviour of include->forward, and also forward->include? Once that's done, can you turn that into a junit test for the jetty module?

        thanks
        Jan

        Show
        Jan Bartel added a comment - Athena, Can you make a simple test webapp to verify the behaviour of include->forward, and also forward->include? Once that's done, can you turn that into a junit test for the jetty module? thanks Jan
        Hide
        Athena Yao added a comment -

        Better patches against the dispatcher that take care of the core problem (include attributes should be hidden after a forward).

        Show
        Athena Yao added a comment - Better patches against the dispatcher that take care of the core problem (include attributes should be hidden after a forward).
        Hide
        Jan Bartel added a comment -

        Patches applied as rev 3191 to trunk and svn rev 3192 to jetty-6.

        Show
        Jan Bartel added a comment - Patches applied as rev 3191 to trunk and svn rev 3192 to jetty-6.

          People

          • Assignee:
            Athena Yao
            Reporter:
            jose ayala
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: