Jetty

Snapshot repository defined in (released) pom

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.7
  • Fix Version/s: None
  • Component/s: Maven
  • Labels:
    None
  • Number of attachments :
    0

Description

The released project 'project' (see for example http://repository.codehaus.org/org/mortbay/jetty/project/6.1.7/project-6.1.7.pom) has repositories and pluginRepositories sections. This repositories section defines snapshots.repository.codehaus.org.
As this project is used as parent in other maven Jetty projects, this definition is pulled in causing my build to load jars from the snapshots repository, I see for example:
Downloading: http://snapshots.repository.codehaus.org/org/mortbay/jetty/servlet-api-2.5/6.1.7/servlet-api-2.5-6.1.7.jar

This messes up my build environment /causes me to loose control over my environment.

repositories and pluginrepositories sections should not be part of the parent-pom (same probably for distributionManagement)
If such definitions are needed maybe a parent project seperate from the modules/aggregation pom is usefull.
At the very least on release the snapshot definitions must be released

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jan Bartel added a comment -

I'm not sure how having the snapshot repo defined could influence anything - after all, you'd have to have specified snapshot versions of something rather than release versions in the pom?

Show
Jan Bartel added a comment - I'm not sure how having the snapshot repo defined could influence anything - after all, you'd have to have specified snapshot versions of something rather than release versions in the pom?
Hide
Permalink
Jesse McConnell added a comment -

on release all snapshots must be resolved, otherwise the release will fail if you are using the maven-release-plugin

its is my understanding that the maven-release-plugin is not used to release jetty, but there is ample checking in place to prevent a jetty release from going out that has any dependencies that rely on -SNAPSHOT versions.

however it would probably be good practice to comment out the snapshot repository definition on the releases of jetty, if I remember right the release plugin does remove them on releases...

as for losing control of your environment if there is a snapshot definition, this should only be the case if you are relying on a snapshot version of some jetty dependency and if you are then that would be normal and you would need this entry in order to obtain updates to that snapshot. Your not losing control of your environment, your making use of the -SNAPSHOT feature of maven. If you are relying on released jetty dependencies and it is checking for snapshots of dependencies of jetty then that is something to isolate in the build and determine what is at fault.

running mvn with -X will give you a wealth of information regarding dependencies, transitive dependencies and how they are being resolved...

if you do find a released jetty artifact with a SNAPSHOT dependency in it (or a -SNAPSHOT property that is being evaluated into a SNAPSHOT dependency) that is the most certainly something in dire need of being bugged and reported.

so...is this last thing the case?

Show
Jesse McConnell added a comment - on release all snapshots must be resolved, otherwise the release will fail if you are using the maven-release-plugin its is my understanding that the maven-release-plugin is not used to release jetty, but there is ample checking in place to prevent a jetty release from going out that has any dependencies that rely on -SNAPSHOT versions. however it would probably be good practice to comment out the snapshot repository definition on the releases of jetty, if I remember right the release plugin does remove them on releases... as for losing control of your environment if there is a snapshot definition, this should only be the case if you are relying on a snapshot version of some jetty dependency and if you are then that would be normal and you would need this entry in order to obtain updates to that snapshot. Your not losing control of your environment, your making use of the -SNAPSHOT feature of maven. If you are relying on released jetty dependencies and it is checking for snapshots of dependencies of jetty then that is something to isolate in the build and determine what is at fault. running mvn with -X will give you a wealth of information regarding dependencies, transitive dependencies and how they are being resolved... if you do find a released jetty artifact with a SNAPSHOT dependency in it (or a -SNAPSHOT property that is being evaluated into a SNAPSHOT dependency) that is the most certainly something in dire need of being bugged and reported. so...is this last thing the case?
Hide
Permalink
Jan Bartel added a comment -

The jetty-7 series has reorganized the structure of the project and has ensured that references to any snapshot repos are not in the released poms.

Of course if there are any further problems, then please reopen.

cheers
Jan

Show
Jan Bartel added a comment - The jetty-7 series has reorganized the structure of the project and has ensured that references to any snapshot repos are not in the released poms. Of course if there are any further problems, then please reopen. cheers Jan

People

  • Assignee:
    Jesse McConnell
    Reporter:
    ajbanck
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: