Jetty
  1. Jetty
  2. JETTY-359

When message id isn't provided the auto-generated message id is ignored

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1.4rc1
    • Component/s: Bayeux
    • Labels:
      None
    • Number of attachments :
      0

      Description

      I guess replacing the generated message with null isn't wasn't the original intention.

        Activity

        Hide
        Tuomas Kiviaho added a comment -

        Index: C:/cygwin/home/kivtuo/scm/jetty/jetty-contrib/contrib/cometd/src/main/java/org/mortbay/cometd/AbstractBayeux.java
        ===================================================================
        — C:/cygwin/home/kivtuo/scm/jetty/jetty-contrib/contrib/cometd/src/main/java/org/mortbay/cometd/AbstractBayeux.java (revision 217)
        +++ C:/cygwin/home/kivtuo/scm/jetty/jetty-contrib/contrib/cometd/src/main/java/org/mortbay/cometd/AbstractBayeux.java (working copy)
        @@ -434,7 +434,7 @@
        ^(to==null?0:to.hashCode())
        ^(from==null?0:from.hashCode());
        id=id<0?-id:id;

        • msg.put(ID_FIELD,Long.toString(id,36));
          + msgId = Long.toString(id,36);
          }
          msg.put(DATA_FIELD,data);
          msg.put(ID_FIELD,msgId);
        Show
        Tuomas Kiviaho added a comment - Index: C:/cygwin/home/kivtuo/scm/jetty/jetty-contrib/contrib/cometd/src/main/java/org/mortbay/cometd/AbstractBayeux.java =================================================================== — C:/cygwin/home/kivtuo/scm/jetty/jetty-contrib/contrib/cometd/src/main/java/org/mortbay/cometd/AbstractBayeux.java (revision 217) +++ C:/cygwin/home/kivtuo/scm/jetty/jetty-contrib/contrib/cometd/src/main/java/org/mortbay/cometd/AbstractBayeux.java (working copy) @@ -434,7 +434,7 @@ ^(to==null?0:to.hashCode()) ^(from==null?0:from.hashCode()); id=id<0?-id:id; msg.put(ID_FIELD,Long.toString(id,36)); + msgId = Long.toString(id,36); } msg.put(DATA_FIELD,data); msg.put(ID_FIELD,msgId);
        Hide
        Tuomas Kiviaho added a comment -

        Component is Bayeux

        Show
        Tuomas Kiviaho added a comment - Component is Bayeux
        Hide
        Greg Wilkins added a comment -

        oops
        fixed
        thanks

        Show
        Greg Wilkins added a comment - oops fixed thanks

          People

          • Assignee:
            Unassigned
            Reporter:
            Tuomas Kiviaho
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: