Jetty JscpC Mojo and dependencies with scope provided

Stefan Reuter added a comment - 01/May/07 3:27 PM Sorry, wrong link. The correct one is: http://fe.reucon.net/fisheye/browse/repos/maven/plugins/maven-openfire-plugin/trunk/src/main/java/com/reucon/maven/plugin/openfire/jspc/JspcMojo.java?r1=659&r2=664

Jan Bartel added a comment - 01/May/07 7:19 PM Hi Stefan, I'm not sure about this change. The maven javadoc says: getArtifacts() All dependencies that this project has, including transitive ones. getDependencyArtifacts() Direct dependencies that this project has. We need all the artifacts, including the transitive ones, don't we?

Stefan Reuter added a comment - 01/May/07 7:27 PM Hm thats right. In fact I used it with a project where only direct depencies where used for compiling. It seems we need the set union of both, right?

Stefan Reuter added a comment - 01/May/07 7:42 PM How about this: private void setUpClassPath(WebAppClassLoader classLoader) throws Exception { String classesDir = classesDirectory.getCanonicalPath(); classesDir = classesDir + (classesDir.endsWith(File.pathSeparator)?"":File.separator); classLoader.addClassPath(classesDir); if (getLog().isDebugEnabled()) getLog().debug( "Adding to classpath classes dir: " +classesDir); Collection artifactsAdded = new HashSet(); for ( Iterator iter = project.getArtifacts().iterator(); iter.hasNext(); ) { Artifact artifact = (Artifact) iter.next(); String filePath = artifact.getFile().getCanonicalPath(); if (!Artifact.SCOPE_TEST.equals( artifact.getScope()) ) { if (getLog().isDebugEnabled()) getLog().debug( "Adding to classpath dependency file: " +filePath); classLoader.addClassPath(filePath); artifactsAdded.add(filePath); } } for ( Iterator iter = project.getDependencyArtifacts().iterator(); iter.hasNext(); ) { Artifact artifact = (Artifact) iter.next(); String filePath = artifact.getFile().getCanonicalPath(); if (!Artifact.SCOPE_TEST.equals( artifact.getScope()) && ! artifactsAdded.contains(filePath)) { if (getLog().isDebugEnabled()) getLog().debug( "Adding to classpath dependency file: " +filePath); classLoader.addClassPath(filePath); } }

Jan Bartel added a comment - 03/May/07 12:45 AM Hi Stefan, I believe if you change the @requiresDependencyResolution to value "compile" instead of runtime, you'll get the scope=provided dependencies. Can you try this out and let me know if it works? I think I'd also have to add some checks to ensure that the jetty jars can't be included (as duplicates) via this mechanism (ie due to a dependency of scope=provided). cheers Jan

Stefan Reuter added a comment - 03/May/07 2:59 PM Hi Jan, changing @requiresDependencyResolution to "compile" fixes the problem. This seems to be the correct solution. Thanks, Stefan

Jan Bartel added a comment - 29/May/07 2:56 AM I've changed the requiresDependencyResolution as mentioned above. At the same time, I removed the dependency on the main jetty jar, leaving just the dependency on the jetty-util jar. See svn rev 1876.