Jetty

ResourceHandler doesn't close resource input stream

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 6.0.0RC0, 6.0.0rc1, 6.0.0rc2, 6.0.0rc3, 6.0.0rc4, 6.0.0, 6.0.1, 6.0.2, 6.0.3, 6.1.0pre0, 6.1.0pre1, 6.1.0pre2, 6.1.0pre3, 6.1.0rc0, 6.1.0rc1, 6.1.0rc2, 6.1.0rc3, 6.1.0, 6.1.1rc0, 6.1.1rc1, 6.1.1, 6.1.2rc0, 6.1.2rc1, 6.1.2rc2, 6.1.2rc3
  • Fix Version/s: 6.1.2rc3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

We ran out of file handles and the problem seemed to be caused by jetty not closing file handles for static resources (images). The files are eventually closed after garbage collection, but that may not happen soon enough.

Problem is in ResourceHandler.handle(...

The included patch is fairly trivial and solves this issue.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eelco Hillenius added a comment -

call me suspicious, but maybe it's even better to do this:

InputStream stream = resource.getInputStream();
if (stream != null) {
try

{ ((HttpConnection.Output) out).sendContent(stream); }

finally

{ stream.close(); }

}

Show
Eelco Hillenius added a comment - call me suspicious, but maybe it's even better to do this: InputStream stream = resource.getInputStream(); if (stream != null) { try { ((HttpConnection.Output) out).sendContent(stream); } finally { stream.close(); } }
Hide
Permalink
Greg Wilkins added a comment -

Actually neither fix was exactly right.....
I fixed it in HttpConnection so other things that pass in inputstreams can benefit

thanks!

Show
Greg Wilkins added a comment - Actually neither fix was exactly right..... I fixed it in HttpConnection so other things that pass in inputstreams can benefit thanks!

People

  • Assignee:
    Unassigned
    Reporter:
    Matej Knopp
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: