Jetty

Testing to see if the stream ends with 3333\n doesn't work under Windows

Details

  • Type: Test Test
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 6.0.1
  • Fix Version/s: None
  • Component/s: J2EE/Extra
  • Labels:
    None
  • Number of attachments :
    1

Description

After updating my local source tree to the head (Nov. 14/2006)

Path: .
URL: http://svn.codehaus.org/jetty/jetty/trunk
Repository Root: http://svn.codehaus.org/jetty
Repository UUID: c7fae8f8-2506-0410-b6b2-ad6cf81c2737
Revision: 1220
Node Kind: directory
Schedule: normal
Last Changed Author: gregw
Last Changed Rev: 1218
Last Changed Date: 2006-11-14 12:21:20 -0500 (Tue, 14 Nov 2006)

The build failed during the running of the test:

d:\jetty\extras\tests\src\test\java\org\mortbay\jetty\WebAppTest.java

It was checking to see if the result stream endsWith("....3333\n"), under Windows \r\n needs to be used.

I have attached a patch to fix this test.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Greg Wilkins added a comment -

Nik, it would be best if it used neither \n or \r\n

Show
Greg Wilkins added a comment - Nik, it would be best if it used neither \n or \r\n
Hide
Permalink
nik gonzalez added a comment -

Greg, you mean not checking if it ends in \n or \r\n? Mark's patch checks if it ends in \n or \r\n, then trims those off and then does the endswith().

Show
nik gonzalez added a comment - Greg, you mean not checking if it ends in \n or \r\n? Mark's patch checks if it ends in \n or \r\n, then trims those off and then does the endswith().
Hide
Permalink
Greg Wilkins added a comment -

sorry - did not see the patch.
eitherway... so long as it works

Show
Greg Wilkins added a comment - sorry - did not see the patch. eitherway... so long as it works
Hide
Permalink
nik gonzalez added a comment -

OK. patch applied.

Show
nik gonzalez added a comment - OK. patch applied.

People

  • Assignee:
    nik gonzalez
    Reporter:
    Mark DeLaFranier
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: