Jetty
  1. Jetty
  2. JETTY-1436

When java.lang.IllegalStateException("Form too large") occurs, the Request instance is left in an inconsistent state, which can lead to further NPE

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.1.26
    • Fix Version/s: None
    • Component/s: HTTP
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      When Jetty throws an java.lang.IllegalStateException("Form too large") from the extractParameters() method in the Request class, the Request instance is left in an inconsistent state. In particular, the _paramsExtracted is set to true, but the _parameters can be null. This leads to a NPE when invoking e.g. the Request.getParameterNames() method, which is how I found the problem.

      Easy to fix, patch included.

        Activity

        Hide
        Jan Bartel added a comment -

        I think this is the same as https://bugs.eclipse.org/bugs/show_bug.cgi?id=353267.

        So I've fixed it the same way.

        Feel free to checkout jetty-6 head, build it and try it out.

        thanks
        Jan

        Show
        Jan Bartel added a comment - I think this is the same as https://bugs.eclipse.org/bugs/show_bug.cgi?id=353267 . So I've fixed it the same way. Feel free to checkout jetty-6 head, build it and try it out. thanks Jan

          People

          • Assignee:
            Unassigned
            Reporter:
            Theo Lassonder
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: