Jetty

Add more setters for jetty-maven-plugin configuration parameters

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 7.4.3
  • Fix Version/s: 7.5.0
  • Component/s: Maven
  • Labels:
    None
  • Number of attachments :
    2

Description

Request via email:

Hi Jan,

My name is Alex. If I'm not wrong, you are the person who knows about jetty-maven-plugin. So here is my story.
I'm developing my maven plugin and it is using your's one. And I've noticed I cannot execute jetty-maven-plugin withing my plugin as I cannot set some private/protected fields which is passed as plugin parameters in the pom file. So I've decided to make an update and create a set of getters and setters so I can set it and execute within java. I know I can use mojo-executor instead but I don't like that approach.

The attached bundle contains README.txt where I described revision I took and modified files. Also It has folders: original and updated, where you can find the updated files and compare with original one.

Also you can add me as a contributor so I can commit it to trunk by myself.

Please review and let me know if you have any questions.

Thanks,

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alex Tunyk added a comment -

here is diff file attached

Show
Alex Tunyk added a comment - here is diff file attached
Hide
Permalink
Alex Tunyk added a comment -

svn diff output

Show
Alex Tunyk added a comment - svn diff output
Hide
Permalink
Michael Gorovoy added a comment -

Greetings,

First of all, Jetty 7 (and Jetty 8) are now entirely backed by git repositories. You can read more about it here. The public SCMURL for Jetty 7 @Codehaus is git@git.codehaus.org/jetty-project.git effective July 07, 2011.

If you are interested in contributing to Jetty project, first thing you should do is subscribe to jetty-dev and jetty-users mailing lists here. Please be aware that commit rights are merit based and granted periodically to people who show long term interest and merit. The best way to start building merit is to become active on the mailing lists and IRC channel (#jetty on irc.codehaus.org), as well as to submit bugs and patches.

In order to streamline the process of reviewing contributions, it is recommended that they are submitted as git formatted patches. For more information please refer to this document.

Cheers,
Michael

Show
Michael Gorovoy added a comment - Greetings, First of all, Jetty 7 (and Jetty 8) are now entirely backed by git repositories. You can read more about it here . The public SCMURL for Jetty 7 @Codehaus is git@git.codehaus.org/jetty-project.git effective July 07, 2011. If you are interested in contributing to Jetty project, first thing you should do is subscribe to jetty-dev and jetty-users mailing lists here . Please be aware that commit rights are merit based and granted periodically to people who show long term interest and merit. The best way to start building merit is to become active on the mailing lists and IRC channel (#jetty on irc.codehaus.org), as well as to submit bugs and patches. In order to streamline the process of reviewing contributions, it is recommended that they are submitted as git formatted patches. For more information please refer to this document . Cheers, Michael
Hide
Permalink
Jan Bartel added a comment -

The diffs were applied to jetty-maven-plugin at codehaus for jetty-7.5.0.

Show
Jan Bartel added a comment - The diffs were applied to jetty-maven-plugin at codehaus for jetty-7.5.0.

People

  • Assignee:
    Jan Bartel
    Reporter:
    Jan Bartel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: