Jetty

jetty-maven-plugin fetches wrong INITIAL_CONTEXT

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Not A Bug
  • Affects Version/s: 7.4.0
  • Fix Version/s: None
  • Component/s: Maven
  • Labels:
    None
  • Number of attachments :
    2

Description

Hi guys,

First, thanks for a great appserver in Jetty, and for a wonderful Maven plugin in jetty-maven-plugin.

I am trying to run my Maven integration-tests against both Jetty and Tomcat using jetty-maven-plugin and tomcat-maven-plugin (see attached pom fragment). It pretty much works.

However it fails because Jetty, when run in the same Maven VM as Tomcat, tries to load org.apache.naming.java.javaURLContextFactory (ie. Tomcat's implementation). I imagine it should be trying org.eclipse.jetty.jndi.java.javaURLContextFactory instead. Clearly there is some kind of VM-level setting going on, but I can't unset it?

I tried adding this to jetty-maven-plugin...

<systemProperties>
<systemProperty>
<name>java.naming.factory.initial</name>
<value>org.eclipse.jetty.jndi.java.javaURLContextFactory</value>

...but that didn't do it.

Is there any way I can get these two to co-exist in the same Maven VM run? Like I said, it's almost working. It'd be really cool to see them both start up, run webtests, and shut down together!

  1. XML File
    jetty-tomcat-pom-snippet.xml
    04/May/11 1:38 AM
    2 kB
    Kennard Consulting
  2. Text File
    maven-debug.txt
    09/May/11 9:32 PM
    363 kB
    Kennard Consulting

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Gorovoy added a comment -

I don't think it is possible to run Jetty and Tomcat within the same VM at the same time, given that they both implement a number of the same APIs and interfaces. That said, you should be able to use Maven profiles to separate the Jetty plugin execution from Tomcat plugin execution, and thus be able to test either one or the other in each run by activating different profiles from the command line.

Show
Michael Gorovoy added a comment - I don't think it is possible to run Jetty and Tomcat within the same VM at the same time, given that they both implement a number of the same APIs and interfaces. That said, you should be able to use Maven profiles to separate the Jetty plugin execution from Tomcat plugin execution, and thus be able to test either one or the other in each run by activating different profiles from the command line.
Hide
Permalink
Greg Wilkins added a comment -

It is definitely possible to run jetty and tomcat in the same JVM.

So we do need to look a little deeper at what is going on here.

Show
Greg Wilkins added a comment - It is definitely possible to run jetty and tomcat in the same JVM. So we do need to look a little deeper at what is going on here.
Hide
Permalink
Jan Bartel added a comment -

Hi Kennard Consulting,

Would it be possible for you to attach the output of a run of your integration tests with -X on the maven command line to produce more output?

thanks
Jan

Show
Jan Bartel added a comment - Hi Kennard Consulting, Would it be possible for you to attach the output of a run of your integration tests with -X on the maven command line to produce more output? thanks Jan
Hide
Permalink
Kennard Consulting added a comment -

Sure. Maven -X log attached.

Note according to WebTest the Jetty server is running fine (all tests pass), but the output log is displaying errors.

Show
Kennard Consulting added a comment - Sure. Maven -X log attached. Note according to WebTest the Jetty server is running fine (all tests pass), but the output log is displaying errors.
Hide
Permalink
Jan Bartel added a comment -

Some more information,

The JNDI libraries have a set way of determining what the jndi provider implementation classes are. This usually involves inspecting a combination of properties files and System properties. Once set, that is what is used by default for the whole jvm. You can get around that by explicitly coding in your own map of environmental property settings into each of your jndi calls, but I don't think that will necessarily help in this case as you don't want to pollute your code with testing related property settings.

Jetty provides a properties file in the jetty-jndi jar that sets up our own jndi impl as a provider. We do NOT explicitly set this as a system property anywhere, as we feel that jetty users should be able to use whatever provider they like. However, it looks like tomcat might not be set up similarly - I see some code in the tomcat codebase that actually explicitly sets System.property with their own initial naming factory:

Catalina.java, line 813:
System.setProperty (javax.naming.Context.INITIAL_CONTEXT_FACTORY,
"org.apache.naming.java.javaURLContextFactory");

Once this is set and has been loaded, I'm not sure if the JNDI libraries ever inspect the System property again. So it could be that tomcat gets in first and sets this property. Note that I don't think the tomcat plugin actually forks a new jvm to execute in (I could be wrong on that, I'm not an expert on the tomcat codebase) (BTW jetty does not fork a new jvm either) so setting the System property is setting it for the maven jvm as as whole.

You could perhaps try using tomcat's jndi impl with jetty, or jetty's jndi impl with tomcat by providing the jar with the jndi impl in it as a dependency to the plugin. You could also try getting some guidance from the tomcat-maven-plugin people as to how their jndi setup really works.

Jan

Show
Jan Bartel added a comment - Some more information, The JNDI libraries have a set way of determining what the jndi provider implementation classes are. This usually involves inspecting a combination of properties files and System properties. Once set, that is what is used by default for the whole jvm. You can get around that by explicitly coding in your own map of environmental property settings into each of your jndi calls, but I don't think that will necessarily help in this case as you don't want to pollute your code with testing related property settings. Jetty provides a properties file in the jetty-jndi jar that sets up our own jndi impl as a provider. We do NOT explicitly set this as a system property anywhere, as we feel that jetty users should be able to use whatever provider they like. However, it looks like tomcat might not be set up similarly - I see some code in the tomcat codebase that actually explicitly sets System.property with their own initial naming factory: Catalina.java, line 813: System.setProperty (javax.naming.Context.INITIAL_CONTEXT_FACTORY, "org.apache.naming.java.javaURLContextFactory"); Once this is set and has been loaded, I'm not sure if the JNDI libraries ever inspect the System property again. So it could be that tomcat gets in first and sets this property. Note that I don't think the tomcat plugin actually forks a new jvm to execute in (I could be wrong on that, I'm not an expert on the tomcat codebase) (BTW jetty does not fork a new jvm either) so setting the System property is setting it for the maven jvm as as whole. You could perhaps try using tomcat's jndi impl with jetty, or jetty's jndi impl with tomcat by providing the jar with the jndi impl in it as a dependency to the plugin. You could also try getting some guidance from the tomcat-maven-plugin people as to how their jndi setup really works. Jan
Hide
Permalink
Kennard Consulting added a comment -

Jan,

Thanks for your prompt response and detailed analysis.

I have opened up a discussion with the Tomcat plugin guys here: http://jira.codehaus.org/browse/MTOMCAT-91

Regards,

Richard.

Show
Kennard Consulting added a comment - Jan, Thanks for your prompt response and detailed analysis. I have opened up a discussion with the Tomcat plugin guys here: http://jira.codehaus.org/browse/MTOMCAT-91 Regards, Richard.
Hide
Permalink
Jan Bartel added a comment -

Hi Richard,

I'm going to close this issue. If you get any info back from the Tomcat guys and you think there is anything that we can do in Jetty to make switching the JNDI factories easier, then please open a new issue and link to this one and we'll take a look.

cheers
Jan

Show
Jan Bartel added a comment - Hi Richard, I'm going to close this issue. If you get any info back from the Tomcat guys and you think there is anything that we can do in Jetty to make switching the JNDI factories easier, then please open a new issue and link to this one and we'll take a look. cheers Jan
Hide
Permalink
Kennard Consulting added a comment -

Jan,

No problem. Thanks for looking into it.

For those coming this way in the future, I worked around this by using Maven profiles and running either Jetty or Tomcat depending on a '-D' flag. See http://metawidget.svn.sourceforge.net/viewvc/metawidget/trunk/pom.xml?revision=1817&view=markup

Regards,

Richard.

Show
Kennard Consulting added a comment - Jan, No problem. Thanks for looking into it. For those coming this way in the future, I worked around this by using Maven profiles and running either Jetty or Tomcat depending on a '-D' flag. See http://metawidget.svn.sourceforge.net/viewvc/metawidget/trunk/pom.xml?revision=1817&view=markup Regards, Richard.

People

  • Assignee:
    Jan Bartel
    Reporter:
    Kennard Consulting
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: