Jetty

jsp include causes ArrayIndexOutOfBoundsException in ByteArrayOutputStream2

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 6.0.1
  • Fix Version/s: None
  • Component/s: JSP
  • Labels:
    None
  • Environment:
    Windows XP, JDK 1.5.0_08
  • Number of attachments :
    0

Description

java.lang.ArrayIndexOutOfBoundsException: 3000
at org.mortbay.util.ByteArrayOutputStream2.writeUnchecked(ByteArrayOutputStream2.java:40)
at org.mortbay.jetty.HttpGenerator$OutputWriter.write(HttpGenerator.java:1355)
at java.io.PrintWriter.write(PrintWriter.java:354)
at org.apache.jasper.runtime.JspWriterImpl.flushBuffer(JspWriterImpl.java:148)
at org.apache.jasper.runtime.JspWriterImpl.flush(JspWriterImpl.java:202)
at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:971)
at org.apache.jasper.runtime.PageContextImpl.include(PageContextImpl.java:641)
at redcondor.web.reports.Report.includeTo(Report.java:359)
at redcondor.web.reports.Report.inputParameters(Report.java:167)
at forms.DomainReportsForm.inputParameters(DomainReportsForm.java:45)
at org.apache.jsp.dashboard.domain.reports_html._jspService(org.apache.jsp.dashboard.domain.reports_html:222)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:358)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:440)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:335)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:445)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:356)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:226)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:627)
at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:266)
at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126)
at redcondor.servlets.ForwardAction.execute(ForwardAction.java:66)
at redcondor.servlets.RoutingServlet.execute(RoutingServlet.java:114)
at redcondor.servlets.RoutingServlet.doPost(RoutingServlet.java:216)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:445)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:356)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:226)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:627)
at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:149)
at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:123)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:141)
at org.mortbay.jetty.Server.handle(Server.java:269)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:430)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:701)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:617)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:199)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:339)
at org.mortbay.jetty.nio.HttpChannelEndPoint.run(HttpChannelEndPoint.java:270)
at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:475)

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. JETTY-151 ArrayIndexOutOfBoundsException from JSP file which is printing/writing long lines

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Greg Wilkins added a comment -

Does this always happen for you?
Do you have some simple JSPs that reproduce the problem?

Was this with JSP 2.0 or JSP 2.1?

Show
Greg Wilkins added a comment - Does this always happen for you? Do you have some simple JSPs that reproduce the problem? Was this with JSP 2.0 or JSP 2.1?
Hide
Permalink
Endre Stølsvik added a comment -

Hey, i know that one! Check out JETTY-151 - I believe this problem is rather far-reaching, maybe pointing towards a race or some other un-/incorrectly handled situation with the "smart buffers" (split, are they?) stuff that apparently happens on the output path? Just speculating, but there's at least a test case in JETTY-151 that reliably, on my setup, produces this under certain circumstances (basically: break connection on client).

Show
Endre Stølsvik added a comment - Hey, i know that one! Check out JETTY-151 - I believe this problem is rather far-reaching, maybe pointing towards a race or some other un-/incorrectly handled situation with the "smart buffers" (split, are they?) stuff that apparently happens on the output path? Just speculating, but there's at least a test case in JETTY-151 that reliably, on my setup, produces this under certain circumstances (basically: break connection on client).
Hide
Permalink
Jeffrey Aguilera added a comment -

I have been able to resolve this in my web app by increasing the maxIdleTime in org.mortbay.jetty.nio.SelectChannelConnector. (The default is 30 seconds.) Apparently, if a page takes longer to assemble than this timeout, a response will be sent back to the client, and any subsequent output from the page runs the risk of triggering this exception because the output buffers are long gone.

To answer Greg's original questions: This only happens with pages that take a long time to execute (long database queries) under JSP 2.1.

Show
Jeffrey Aguilera added a comment - I have been able to resolve this in my web app by increasing the maxIdleTime in org.mortbay.jetty.nio.SelectChannelConnector. (The default is 30 seconds.) Apparently, if a page takes longer to assemble than this timeout, a response will be sent back to the client, and any subsequent output from the page runs the risk of triggering this exception because the output buffers are long gone. To answer Greg's original questions: This only happens with pages that take a long time to execute (long database queries) under JSP 2.1.
Hide
Permalink
kris wehner added a comment -

I am unable to workaround the issue by increasing my timeout; I disagree with Jeffery's statement above, at least for the case I am tripping across.

My stack trace is exactly as above. This is preventing me from adopting jetty, which is very unfortunate.

Show
kris wehner added a comment - I am unable to workaround the issue by increasing my timeout; I disagree with Jeffery's statement above, at least for the case I am tripping across. My stack trace is exactly as above. This is preventing me from adopting jetty, which is very unfortunate.
Hide
Permalink
Jan Bartel added a comment -

Please see the resolution comment on issue http://jira.codehaus.org/browse/JETTY-151 .
I think this answers this issue too, put please add more information to this issue if you have a different test case to demonstrate aberrant behaviour.

Show
Jan Bartel added a comment - Please see the resolution comment on issue http://jira.codehaus.org/browse/JETTY-151 . I think this answers this issue too, put please add more information to this issue if you have a different test case to demonstrate aberrant behaviour.
Hide
Permalink
Jan Bartel added a comment -

Resolving it for now unless there is more info forthcoming.

Show
Jan Bartel added a comment - Resolving it for now unless there is more info forthcoming.
Hide
Permalink
Jan Bartel added a comment -

I've committed a fix to svn trunk. The ArrayIndexOutOfBounds exception will no longer occur if the connection is closed while it is still being written to. Please can you confirm this fixes your issue.

Show
Jan Bartel added a comment - I've committed a fix to svn trunk. The ArrayIndexOutOfBounds exception will no longer occur if the connection is closed while it is still being written to. Please can you confirm this fixes your issue.

People

  • Assignee:
    Jan Bartel
    Reporter:
    Jeffrey Aguilera
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: