Jetty

Utf8StringBuffer incorrectly handles characters outside of the basic multilingual plane

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.25
  • Fix Version/s: 6.1.27
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    3

Description

In the Apache Solr project, we had some problems with jetty supporting Unicode characters outside
of the basic multilingual plane (codepoints greater than 0xffff).

The problem boils down to Utf8StringBuffer, all of the utf8 logic looks generally correct, but at
the end when it is time to append to the underlying StringBuffer, it needs to append the two
UTF-16 surrogates for characters in this range... its a rather simple fix.

The patch is against http://svn.codehaus.org/jetty/jetty/branches/jetty-6.1 (I hope this is correct?)

  1. Text File
    AbstractGenerator.patch
    09/Mar/11 9:43 AM
    10 kB
    Bernd Fehling
  2. Text File
    JETTY-1340.patch
    25/Feb/11 11:22 AM
    4 kB
    Robert Muir
  3. Text File
    jettyUnicode.patch
    25/Feb/11 10:27 AM
    2 kB
    Robert Muir

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. JETTY-1328 org.mortbay.jetty.HttpConnection.printWriter("UTF-8") returns a broken UTF-8 writer wrt. Strings containing surrogate characters

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Robert Muir added a comment -

updated patch, there was a similar bug in the UTF8 writer as well (I added a new test for this one)

Now everything appears to work with all of unicode in jetty.

Show
Robert Muir added a comment - updated patch, there was a similar bug in the UTF8 writer as well (I added a new test for this one) Now everything appears to work with all of unicode in jetty.
Hide
Permalink
Greg Wilkins added a comment -

Note that this has been fixed in jetty-7 already.
I will leave this open until we back port to jetty 6

Show
Greg Wilkins added a comment - Note that this has been fixed in jetty-7 already. I will leave this open until we back port to jetty 6
Hide
Permalink
Robert Muir added a comment -

Thanks Greg, you are right: after the fact, I checked jetty 7 out of curiousity and at a glance, it looks like all of this stuff is correct there.

Show
Robert Muir added a comment - Thanks Greg, you are right: after the fact, I checked jetty 7 out of curiousity and at a glance, it looks like all of this stuff is correct there.
Hide
Permalink
Bernd Fehling added a comment -

The patch for AbstracGenerator.java has to be used with the patched version of AbstractGenerator.java
from JETTY-1340 patch supplied by Robert.
This will fix UTF-8 handling for unicode above BMP.

Show
Bernd Fehling added a comment - The patch for AbstracGenerator.java has to be used with the patched version of AbstractGenerator.java from JETTY-1340 patch supplied by Robert. This will fix UTF-8 handling for unicode above BMP.
Hide
Permalink
Greg Wilkins added a comment -

backported jetty-7 UTF handling

Show
Greg Wilkins added a comment - backported jetty-7 UTF handling

People

  • Assignee:
    Greg Wilkins
    Reporter:
    Robert Muir
Vote (3)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: