Jetty

Enhance jetty-ant to have the port for the built-in connector be configurable

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 7.1.5
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

After running into a minor problem with jetty-ant where it deploys a default connector listening on port 8080 while another application was listening on that port. Browsing in the sources shows that the default selector's port is hard coded for 8080. I proposed the an enhancement in IRC and was given a +1 to create this issue for tracking it. That being said, my plan is to enhance the JettyRunTask to allow for an optional attribute for the jetty XML element to configure the port that the built-in/default connector listens on.

I plan on performing the work for this effort and the work will include the appropriate unit test(s).

  1. XML File
    build.xml
    23/Jun/10 4:09 PM
    0.4 kB
    Jeremy Whitlock
  2. Text File
    JETTY-1241_without_tests.patch
    23/Jun/10 4:07 PM
    4 kB
    Jeremy Whitlock

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeremy Whitlock added a comment -

Attached is the patch I crafted to enable changing the default port Jetty listens on for the default connector deployed with jetty-ant. While I have proven that this works through test Ant build files, the attachment does not contain any unit tests due to me not having found a good way to unit test such a thing at this point. Without jetty-ant having any unit tests to this point, I wonder if further effort is necessary...

Show
Jeremy Whitlock added a comment - Attached is the patch I crafted to enable changing the default port Jetty listens on for the default connector deployed with jetty-ant. While I have proven that this works through test Ant build files, the attachment does not contain any unit tests due to me not having found a good way to unit test such a thing at this point. Without jetty-ant having any unit tests to this point, I wonder if further effort is necessary...
Hide
Permalink
Jeremy Whitlock added a comment -

Attaching an example build.xml that showcases the new attribute and which can be used for testing.

Show
Jeremy Whitlock added a comment - Attaching an example build.xml that showcases the new attribute and which can be used for testing.
Hide
Permalink
Jeremy Whitlock added a comment -

I have attached a patch that allows you to set the port that jetty-ant uses for its default connector port. A default connector is deployed when you don't configure any connectors within the jetty task in your Ant build file. I have also attached a sample build.xml that can be used for testing. Here is example output proving this patch works:

$ ant test-default
Buildfile: build.xml

test-default:
[jetty] Configuring Jetty for project: Jetty Test
[jetty] 2010-06-23 15:05:33.414:INFO::jetty-7.1.4.v20100610
[jetty] 2010-06-23 15:05:33.750:INFO::Started SelectChannelConnector@0.0.0.0:8080
...

$ ant test-custom
Buildfile: build.xml

test-custom:
[jetty] Configuring Jetty for project: Jetty Test
[jetty] 2010-06-23 15:05:40.537:INFO::jetty-7.1.4.v20100610
[jetty] 2010-06-23 15:05:40.609:INFO::Started SelectChannelConnector@0.0.0.0:9090
...

As you can see, when no port is specified, the default of 8080 is used while specifying the jettyPort in the jetty task overrides the default. With the way the JettyRunTask is written and how Ant test cases allow testing, I still haven't figured out a good way to write a suitable unit test. If you think there is no need for one and the code clearly works as designed, let me know and I'll stop putting time into it, since there aren't any unit tests already in the project. Otherwise, I'll continue working on devising a way to write unit tests for this.

Show
Jeremy Whitlock added a comment - I have attached a patch that allows you to set the port that jetty-ant uses for its default connector port. A default connector is deployed when you don't configure any connectors within the jetty task in your Ant build file. I have also attached a sample build.xml that can be used for testing. Here is example output proving this patch works: $ ant test-default Buildfile: build.xml test-default: [jetty] Configuring Jetty for project: Jetty Test [jetty] 2010-06-23 15:05:33.414:INFO::jetty-7.1.4.v20100610 [jetty] 2010-06-23 15:05:33.750:INFO::Started SelectChannelConnector@0.0.0.0:8080 ... $ ant test-custom Buildfile: build.xml test-custom: [jetty] Configuring Jetty for project: Jetty Test [jetty] 2010-06-23 15:05:40.537:INFO::jetty-7.1.4.v20100610 [jetty] 2010-06-23 15:05:40.609:INFO::Started SelectChannelConnector@0.0.0.0:9090 ... As you can see, when no port is specified, the default of 8080 is used while specifying the jettyPort in the jetty task overrides the default. With the way the JettyRunTask is written and how Ant test cases allow testing, I still haven't figured out a good way to write a suitable unit test. If you think there is no need for one and the code clearly works as designed, let me know and I'll stop putting time into it, since there aren't any unit tests already in the project. Otherwise, I'll continue working on devising a way to write unit tests for this.
Hide
Permalink
Jesse McConnell added a comment -

applied to jetty-ant, thanks!

Show
Jesse McConnell added a comment - applied to jetty-ant, thanks!

People

  • Assignee:
    Jesse McConnell
    Reporter:
    Jeremy Whitlock
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2h
Original Estimate - 2 hours
Remaining:
2h
Remaining Estimate - 2 hours
Logged:
Not Specified
Time Spent - Not Specified