Jetty

StdErrLog#warn no longer propect against a null Throwable parameter

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.22
  • Fix Version/s: 6.1.23
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

In Jetty 6.1.22 the org.mortbay.jetty.util.StdErrLog#warn(String, Throwable) method no longer protects against a null Throwable parameter.

If this method is called (for example through the Servlet log API) with a null Throwable it will result in a NPE on line 212. I didn't go back to every single version but in Jetty 6.1.18 this is not an issue.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Gorovoy added a comment -

This issue was introduced by a fix for the JETTY-1129.

Show
Michael Gorovoy added a comment - This issue was introduced by a fix for the JETTY-1129 .
Hide
Permalink
Michael Gorovoy added a comment -

Fixed the NPE by adding guard checks. Added test harness to test for all possible situations where the message string and/or argument could be null to prevent regression.

Show
Michael Gorovoy added a comment - Fixed the NPE by adding guard checks. Added test harness to test for all possible situations where the message string and/or argument could be null to prevent regression.
Hide
Permalink
Greg Wilkins added a comment -

Applied thanks

Show
Greg Wilkins added a comment - Applied thanks
Hide
Permalink
Michael Gorovoy added a comment -

Greg,

There was a test harness in this patch (modules/util/src/test/java/org/mortbay/log/StdErrLogTest.java) that never made it into the commit. Was it intentional, or did it just get lost?

-Michael

Show
Michael Gorovoy added a comment - Greg, There was a test harness in this patch (modules/util/src/test/java/org/mortbay/log/StdErrLogTest.java) that never made it into the commit. Was it intentional, or did it just get lost? -Michael
Hide
Permalink
Greg Wilkins added a comment -

I did see that test harness. I must have forgotten to svn add it.

I'll add again.

Show
Greg Wilkins added a comment - I did see that test harness. I must have forgotten to svn add it. I'll add again.

People

  • Assignee:
    Greg Wilkins
    Reporter:
    Olivier Modica
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: