Jetty

NPE in SslHttpChannelEndPoint.wrap

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 6.1.15
  • Fix Version/s: None
  • Component/s: Security and SSL
  • Labels:
    None
  • Environment:
    RHEL4
  • Number of attachments :
    0

Description

Saw this exception during our tests:

java.lang.NullPointerException
	at org.mortbay.jetty.security.SslHttpChannelEndPoint.wrap(SslHttpChannelEndPoint.java:645)
	at org.mortbay.jetty.security.SslHttpChannelEndPoint.flush(SslHttpChannelEndPoint.java:406)
	at org.mortbay.jetty.HttpGenerator.flush(HttpGenerator.java:710)
	at org.mortbay.jetty.AbstractGenerator$Output.flush(AbstractGenerator.java:568)
	at org.mortbay.jetty.HttpConnection$Output.flush(HttpConnection.java:947)
	at org.mortbay.jetty.AbstractGenerator$OutputWriter.flush(AbstractGenerator.java:733)
	at java.io.PrintWriter.flush(PrintWriter.java:276)
	at org.dom4j.io.XMLWriter.flush(XMLWriter.java:272)
	at com.electriccloud.xml.XmlUtil.toXml(XmlUtil.java:195)
	at com.electriccloud.xml.XmlUtil.toXml(XmlUtil.java:160)
	at com.electriccloud.commander.server.XmlRequestHandler.handle(XmlRequestHandler.java:375)
	at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:324)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:535)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:398)
	at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
	at org.mortbay.jetty.nio.SelectChannelConnector$RetryContinuation.run(SelectChannelConnector.java:525)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:520)

The exception happened on one thread while another thread was calling Server.stop(), so it might be a race condition in the shutdown logic.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anders Wallgren added a comment -

So far we've only see this once, so I wouldn't call it reproducible.

Show
Anders Wallgren added a comment - So far we've only see this once, so I wouldn't call it reproducible.
Hide
Permalink
Greg Wilkins added a comment -

It is almost certainly a race condition.
If you use a graceful shutdown, you should avoid this type of issue, as it lets requests complete before proceeding.

However we are continuing to look for ways to avoid such exceptions without slowing the main code. So I've converted this issue
to "improvement" and we'll have a look to see if there are steps we can take for this particular variety.

Show
Greg Wilkins added a comment - It is almost certainly a race condition. If you use a graceful shutdown, you should avoid this type of issue, as it lets requests complete before proceeding. However we are continuing to look for ways to avoid such exceptions without slowing the main code. So I've converted this issue to "improvement" and we'll have a look to see if there are steps we can take for this particular variety.
Hide
Permalink
Greg Wilkins added a comment -

Closing for now.

We have done some other improvements in this area, so please reopen if you see this again after 6.1.19

Show
Greg Wilkins added a comment - Closing for now. We have done some other improvements in this area, so please reopen if you see this again after 6.1.19
Hide
Permalink
Scott Stanton added a comment -

I have seen this failure in 6.1.21.

Show
Scott Stanton added a comment - I have seen this failure in 6.1.21.

People

  • Assignee:
    Unassigned
    Reporter:
    Anders Wallgren
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: