Jetty

jetty-runner fails when jetty-runner.jar is included in the war

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 7.0.0.pre5
  • Fix Version/s: None
  • Component/s: J2EE/Extra
  • Labels:
    None
  • Environment:
    Win32-XP
  • Number of attachments :
    0

Description

Jetty-runner fails if the war to run embeds jetty-runner.jar as one of its libs with the following error:
java.lang.IllegalArgumentException: Object is not of type class org.mortbay.jetty.webapp.WebAppContext

The goal was to create a self-executable war file similarly to Hudson can be run (see the blog post at http://weblogs.java.net/blog/kohsuke/archive/2007/02/hudson_became_s.html and implementation at http://fisheye4.atlassian.com/browse/~raw,r=16013/hudson/trunk/hudson/extras/executable-war/src/main/java/Main.java) but instead of Winstone, use Jetty. However, if I include jetty-runner.jar with the war (so the main class in the war could extract it) it fails with an exception that looks like a classloader issue. If I don't include jetty-runner.jar in the war, the runner works as expected.

Could be related to http://jira.codehaus.org/browse/JETTY-518 - although it sounded like the intention of that issue was to add a goal to maven jetty plugin to create a distribution package (zip, tar) with start-up scripts (rather than make it possible to create self-executable war with Jetty).

Let me know if I could try some Jetty configuration options to work around the issue. If the issue is not clear, I can create a test case (but it failed the same way with any wars I locally tested with).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jan Bartel added a comment -

Kalle,

Do you mean that you get that exception when you try and execute the war, or if you use the war in a container? Can you attach a simple example of such a war?

thanks
Jan

Show
Jan Bartel added a comment - Kalle, Do you mean that you get that exception when you try and execute the war, or if you use the war in a container? Can you attach a simple example of such a war? thanks Jan
Hide
Permalink
Kalle Korhonen added a comment -

I get the exception if I execute java -jar jetty-runner-7.0.0.pre5.jar webapp.war. Basically a "self-executable" war would work so that you run java -jar webapp.war, the main class would extract the jetty-runner.jar that is embedded in the war file to a temp dir and then execute the runner's main with the war file as an argument.

I'll make a stripped down simple example and attach it to the issue.

Show
Kalle Korhonen added a comment - I get the exception if I execute java -jar jetty-runner-7.0.0.pre5.jar webapp.war. Basically a "self-executable" war would work so that you run java -jar webapp.war, the main class would extract the jetty-runner.jar that is embedded in the war file to a temp dir and then execute the runner's main with the war file as an argument. I'll make a stripped down simple example and attach it to the issue.
Hide
Permalink
Kalle Korhonen added a comment -

Upon further examination, it's only an issue if there's jetty-web.xml configuration bundled in the war. To workaround issues with running Tapestry web applications in Eclipse, I had added jetty-web.xml in WEB-INF folder, configured as follows:
<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE Configure PUBLIC "-//Mort Bay Consulting//DTD Configure//EN" "http://jetty.mortbay.org/configure.dtd">

<Configure class="org.mortbay.jetty.webapp.WebAppContext">
<Set name="parentLoaderPriority">true</Set>
</Configure>

But even if don't set anything in the configuration, it fails - apparently because of the Configure class.. line. This may be a user error - I could see why this wouldn't be a supported use case with jetty-runner. If I remove jetty-web.xml the war runs (even if jetty-runner.jar is bundled into the war). I can use -Dorg.mortbay.jetty.webapp.parentLoaderPriority=true instead so this should be ok.

Finally, it seems to me that jetty-runner should declare all of it's dependency as optional (or perhaps as provided) in it's pom.xml. Thanks for looking into the issue; close with comments if you feel there are no actions left to be taken regarding this issue.

Show
Kalle Korhonen added a comment - Upon further examination, it's only an issue if there's jetty-web.xml configuration bundled in the war. To workaround issues with running Tapestry web applications in Eclipse, I had added jetty-web.xml in WEB-INF folder, configured as follows: <?xml version="1.0" encoding="ISO-8859-1"?> <!DOCTYPE Configure PUBLIC "-//Mort Bay Consulting//DTD Configure//EN" "http://jetty.mortbay.org/configure.dtd"> <Configure class="org.mortbay.jetty.webapp.WebAppContext"> <Set name="parentLoaderPriority">true</Set> </Configure> But even if don't set anything in the configuration, it fails - apparently because of the Configure class.. line. This may be a user error - I could see why this wouldn't be a supported use case with jetty-runner. If I remove jetty-web.xml the war runs (even if jetty-runner.jar is bundled into the war). I can use -Dorg.mortbay.jetty.webapp.parentLoaderPriority=true instead so this should be ok. Finally, it seems to me that jetty-runner should declare all of it's dependency as optional (or perhaps as provided) in it's pom.xml. Thanks for looking into the issue; close with comments if you feel there are no actions left to be taken regarding this issue.
Hide
Permalink
Greg Wilkins added a comment -

I don't think we will change anything in jetty-6 as the handing of container classes within the WAR is a little complex.

However, I might suggest that you move the jetty-runner.jar out of WEB-INF/lib so it is a resource somewhere in the war, but not on the webapp classpath. You'd need some maven magic to do this, but it should not be too difficult.

Show
Greg Wilkins added a comment - I don't think we will change anything in jetty-6 as the handing of container classes within the WAR is a little complex. However, I might suggest that you move the jetty-runner.jar out of WEB-INF/lib so it is a resource somewhere in the war, but not on the webapp classpath. You'd need some maven magic to do this, but it should not be too difficult.
Hide
Permalink
Kalle Korhonen added a comment -

Though I got it to work now, I agree, jetty-runner probably shouldn't be in the webapp classpath. Not too difficult to to do that with dependency:copy (just as a note for others)

Show
Kalle Korhonen added a comment - Though I got it to work now, I agree, jetty-runner probably shouldn't be in the webapp classpath. Not too difficult to to do that with dependency:copy (just as a note for others)

People

  • Assignee:
    Jan Bartel
    Reporter:
    Kalle Korhonen
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: