JBehave

Some unit tests fail on Windows due to cr/lf encoding

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.5.4
  • Fix Version/s: 3.6
  • Component/s: Core
  • Labels:
    None
  • Environment:
    windows vista, java 1.6.0-31
  • Number of attachments :
    0

Description

When building jbehave-core on windows, 2 unit tests fail because the files are compared with cr/lf line endings (this may depend on the git default setting for text files) but the actual test results contain lf line endings only (since the text is never written or read).

I ignored that until now with skipTests=true, I assume nobody else uses Windows to build jbehave, if you want, I can fix the tests.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alexander Lehmann added a comment -

the test are shouldReportEventsToHtmlOutput and shouldReportEventsToXmlOutput

Show
Alexander Lehmann added a comment - the test are shouldReportEventsToHtmlOutput and shouldReportEventsToXmlOutput
Hide
Permalink
Mauro Talevi added a comment -

A patch for Windows would be welcome.

Show
Mauro Talevi added a comment - A patch for Windows would be welcome.
Hide
Permalink
Alexander Lehmann added a comment -

Turns out this is handled for the created file but not for the reference file, if the files are checked out with cr/lf conversion e.g. on tortoisegit, the tests fail

Show
Alexander Lehmann added a comment - Turns out this is handled for the created file but not for the reference file, if the files are checked out with cr/lf conversion e.g. on tortoisegit, the tests fail
Hide
Permalink
Alexander Lehmann added a comment -

https://github.com/alexlehm/jbehave-core/commit/c1bc479f81e4c0440ed1089963334f6c659e87de

Show
Alexander Lehmann added a comment - https://github.com/alexlehm/jbehave-core/commit/c1bc479f81e4c0440ed1089963334f6c659e87de
Mauro Talevi made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 3.6 [ 17721 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Unassigned
    Reporter:
    Alexander Lehmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: