Add an optional StoryFinder class element to @UsingPaths annotation

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.6
  • Component/s: Core
  • Labels:

Description

Currently @UsingPaths is using one fixed instance of StoryFinder class.
In order to use a custom StoryFinder class with the annotation, I would like to include an optional storyFinder element in the @UsingPaths annotation.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Cristiano Gavião added a comment -

Since we are informing the path and the StoryFinder class in the @UsingPaths, we need a runStoriesAsPaths() method without parameter in Embedder class.
Or perhaps a new Embedder abstract class that already implements the run() method of Embeddable interface.

Show
Cristiano Gavião added a comment - Since we are informing the path and the StoryFinder class in the @UsingPaths, we need a runStoriesAsPaths() method without parameter in Embedder class. Or perhaps a new Embedder abstract class that already implements the run() method of Embeddable interface.
Hide
Permalink
Mauro Talevi added a comment -

@UsingPaths is used by the AnnotatedPathRunner and the paths configured are passed to the Embedder runStoriesAsPaths(List<String>) method.

If you want, you can use the annotated builder to get the paths directly from the annotation. 

new AnnotationBuilder(A.class).findPaths()

We can devise other uses of @UsingPaths but it should be tracked by another Jira issue.

Show
Mauro Talevi added a comment - @UsingPaths is used by the AnnotatedPathRunner and the paths configured are passed to the Embedder runStoriesAsPaths(List<String>) method. If you want, you can use the annotated builder to get the paths directly from the annotation. 
new AnnotationBuilder(A.class).findPaths()
We can devise other uses of @UsingPaths but it should be tracked by another Jira issue.

People

  • Assignee:
    Mauro Talevi
    Reporter:
    Cristiano Gavião
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: