JBehave

ant copy-depedencies improvements

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.5.4
  • Fix Version/s: 3.6
  • Component/s: Core
  • Labels:
    None
  • Environment:
    any
  • Number of attachments :
    0

Description

I have 3 suggestions for improvements of the ant copy-dependencies process (or 2 suggestions and one question=

  • update maven-ant-tasks to the current version (2.1.3)
  • the maven-ant-tasks jar shouldn't be in lib (since it is not a dependency of jbehave) maybe if should be in a subdir ant
  • is it intentional that the binary distribution doesn't contain any binaries? It just downloads the jbehave jars along with the dependencies.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mauro Talevi added a comment -

Please feel free to attach patch for first two points.

Yes, it is intentional to avoid having big bloated distributions. It's very easy to download and cache dependencies.

Show
Mauro Talevi added a comment - Please feel free to attach patch for first two points. Yes, it is intentional to avoid having big bloated distributions. It's very easy to download and cache dependencies.
Hide
Permalink
Alexander Lehmann added a comment - - edited

fix for the first two items

https://github.com/alexlehm/jbehave-core/commit/3a8aeae9806e930a29bc63943c0edea1fbac89b4

(not sure if I have to send a pull request, I'm still somewhat of a git beginner)

Show
Alexander Lehmann added a comment - - edited fix for the first two items https://github.com/alexlehm/jbehave-core/commit/3a8aeae9806e930a29bc63943c0edea1fbac89b4 (not sure if I have to send a pull request, I'm still somewhat of a git beginner)
Hide
Permalink
Mauro Talevi added a comment -

Pulled https://github.com/alexlehm/jbehave-core/commit/3a8aeae9806e930a29bc63943c0edea1fbac89b4

Show
Mauro Talevi added a comment - Pulled https://github.com/alexlehm/jbehave-core/commit/3a8aeae9806e930a29bc63943c0edea1fbac89b4

People

  • Assignee:
    Unassigned
    Reporter:
    Alexander Lehmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: