JBehave
  1. JBehave
  2. JBEHAVE-543

Before/After Story/Scenario methods could accept parameters that have meaning at that moment

    Details

    • Type: New Feature New Feature
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5
    • Component/s: Core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      For example -

      public void myBeforeStory(@Named("someMetaTag") String someMetaTag) { .. }

      This would be a poor-mans version of JBEHAVE-541

        Activity

        Hide
        Mauro Talevi added a comment -

        Hi Adriano, I've pulled your commits. Did not see any issues with them.

        What do you mean by refactoring StepCreator to only have MethodInvoker?

        Examples of the new feature would be most welcome.

        Thanks for your great work!

        Show
        Mauro Talevi added a comment - Hi Adriano, I've pulled your commits. Did not see any issues with them. What do you mean by refactoring StepCreator to only have MethodInvoker? Examples of the new feature would be most welcome. Thanks for your great work!
        Hide
        Adriano Bonat added a comment -

        Hey Mauro,

        I've checked in some examples using this feature and after some thought I didn't see a reason to report the execution of the parametrized before/after annotations, so I've removed the TODO.

        About the refactoring in StepCreator, the idea is delegate the method invocation in the ParametrisedStep to the MethodInvoker that this task introduced. I've started this yesterday but still need to see how can I keep the current reporting calls working as they do currently.

        Sorry for the delayed reply

        Show
        Adriano Bonat added a comment - Hey Mauro, I've checked in some examples using this feature and after some thought I didn't see a reason to report the execution of the parametrized before/after annotations, so I've removed the TODO. About the refactoring in StepCreator, the idea is delegate the method invocation in the ParametrisedStep to the MethodInvoker that this task introduced. I've started this yesterday but still need to see how can I keep the current reporting calls working as they do currently. Sorry for the delayed reply
        Hide
        Mauro Talevi added a comment -

        Adriano,

        resolving issue as it is feature complete.

        Any additional refactor should be dealt with by opening a separate issue.

        Show
        Mauro Talevi added a comment - Adriano, resolving issue as it is feature complete. Any additional refactor should be dealt with by opening a separate issue.
        Hide
        Adriano Bonat added a comment -

        Mauro, please have a look in my branch since there are 3 commits not merged:
        https://github.com/tanob/jbehave-core/commits/jbehave-543

        Thanks

        Show
        Adriano Bonat added a comment - Mauro, please have a look in my branch since there are 3 commits not merged: https://github.com/tanob/jbehave-core/commits/jbehave-543 Thanks
        Hide
        Mauro Talevi added a comment -

        Merged, thanks!

        Show
        Mauro Talevi added a comment - Merged, thanks!

          People

          • Assignee:
            Mauro Talevi
            Reporter:
            Paul Hammant
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: