Replace Ensure methods with Hamcrest direct invocations

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.0
  • Component/s: Core
  • Labels:
    None

Description

Ensure is a very thin layer over Hamcrest, with very little benefit apart from using "ensure" terminology in place of "assert". The ensureThat(boolean) method can be confusing too. Better to allow direct use of Hamcrest or other libraries to enable the assertion or verification.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brian Repko added a comment -

Not sure that these are needed - they are part of JUnit - I just tell people to ignore them and use JUnit's Asserts

Show
Brian Repko added a comment - Not sure that these are needed - they are part of JUnit - I just tell people to ignore them and use JUnit's Asserts
Hide
Permalink
Mauro Talevi added a comment -

Precisely my point. One should be able to use any assertion library one prefers, Hamcrest, JUnit, etc ...

Show
Mauro Talevi added a comment - Precisely my point. One should be able to use any assertion library one prefers, Hamcrest, JUnit, etc ...
Hide
Permalink
Brian Repko added a comment -

Ah, got it - perfect - thanks, Mauro.

Show
Brian Repko added a comment - Ah, got it - perfect - thanks, Mauro.

People

  • Assignee:
    Mauro Talevi
    Reporter:
    Mauro Talevi
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: