Details
-
Type:
Wish
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 2.1
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
PASSING and SILENT are identical method bodies
The same is true of FAILING and RETHROW
[ moving past that issue ]
Could y'all make one more strategy ?
/**
* This will continue the scenario as PASSING would, but at the end, remember that there was an issue during the run, and throw it again then.
*/
PendingErrorStrategy FAIL_LATER = new PendingErrorStrategy() {
public void handleError(Throwable throwable) {
// ??
}
};
Note, I've even given you some /** Javadoc */ for this, as http://jbehave.org/javadoc/latest/core/org/jbehave/scenario/errors/PendingErrorStrategy.html is a little sparse on information 
Activity
Hide
Paul Hammant
added a comment -
It's a pretty open arch. I can implement something that works for me, and donate back 
Show
Paul Hammant
added a comment - It's a pretty open arch. I can implement something that works for me, and donate back
Paul - PASSING and SILENT are implementations of different types (albeit one extending the other). Similarly, for FAILING and RETHROW.
They address different concerns - the ErrorStrategy and PendingErrorStrategy - and the fact that the implementation is the same is accidental.
This is expressed by the fact also by their different names.
As for the additional PendingErrorStrategy - could you please provide a test case (updating the existing ScenarioRunnerBehaviour) or a scenario to show the use case.