Details

    • Type: Improvement Improvement
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Component/s: core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      issue migrated from sourceforge

      Hello-

      why are you using == inside the default impl of
      FollowingSiblingAxisIterator? I would suggest changing
      to .equals() ?

      line of code is:
      <pre>
      else if ( eachChild == this.contextNode )
      </pre>
      My object model does not guarantee == for equality. I
      have custom impl as a workaround so this is not a big
      deal.

      Thanks

      -David

      (the answer is that DOM doesnt support equals. I'm not just closing this because it may be worthwhile to add a node equality test to the navigator interface - brian)

        Activity

        Brian Ewins made changes -
        Field Original Value New Value
        Fix Version/s 2.0 [ 11516 ]
        Component/s core [ 11383 ]
        Environment
        Description issue migrated from sourceforge

        Hello-

        why are you using == inside the default impl of
        FollowingSiblingAxisIterator? I would suggest changing
        to .equals() ?

        line of code is:
        &lt;pre&gt;
        else if ( eachChild == this.contextNode )
        &lt;/pre&gt;
        My object model does not guarantee == for equality. I
        have custom impl as a workaround so this is not a big
        deal.

        Thanks

        -David

        (the answer is that DOM doesnt support equals. I'm not just closing this because it may be worthwhile to add a node equality test to the navigator interface - brian)
        issue migrated from sourceforge

        Hello-

        why are you using == inside the default impl of
        FollowingSiblingAxisIterator? I would suggest changing
        to .equals() ?

        line of code is:
        <pre>
        else if ( eachChild == this.contextNode )
        </pre>
        My object model does not guarantee == for equality. I
        have custom impl as a workaround so this is not a big
        deal.

        Thanks

        -David

        (the answer is that DOM doesnt support equals. I'm not just closing this because it may be worthwhile to add a node equality test to the navigator interface - brian)

          People

          • Assignee:
            Unassigned
            Reporter:
            Brian Ewins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: