jaxen

Upgrade to Maven 2

Details

  • Type: Task Task
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.1
  • Fix Version/s: 1.1.3
  • Component/s: Build
  • Labels:
    None
  • Number of attachments :
    5

Description

One of these days we should move forward to Maven 2, but not for Jaxen 1.1.

Attachments

  1. Text File
    0001-maven-2-build-support.patch
    26/Oct/09 2:20 PM
    142 kB
    Brian Ewins
  2. Text File
    0001-Specified-groupId-and-version-for-reporting-plugins.patch
    05/Nov/09 8:00 AM
    4 kB
    Aleksander Adamowski
  3. Text File
    jaxen-maven2-upgrade.patch
    15/Oct/09 5:41 AM
    10 kB
    Aleksander Adamowski
  4. Text File
    mvn.patch
    26/Oct/09 9:51 AM
    15 kB
    Brian Ewins
  5. XML File
    pom.xml
    15/Oct/09 5:40 AM
    10 kB
    Aleksander Adamowski

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Aleksander Adamowski added a comment -

I gave a shot at doing it automatically using maven-one-plugin:

mvn one:convert

The result is mostly OK, but some dependencies need to have their version numbers updated. The unit tests run all OK.

Attaching patch (which only covers the new pom.xml) and the raw pom.xml itself.

Show
Aleksander Adamowski added a comment - I gave a shot at doing it automatically using maven-one-plugin: mvn one:convert The result is mostly OK, but some dependencies need to have their version numbers updated. The unit tests run all OK. Attaching patch (which only covers the new pom.xml) and the raw pom.xml itself.
Hide
Permalink
Aleksander Adamowski added a comment -

The pom.xml

Show
Aleksander Adamowski added a comment - The pom.xml
Hide
Permalink
Aleksander Adamowski added a comment -

The patch.

Show
Aleksander Adamowski added a comment - The patch.
Hide
Permalink
Aleksander Adamowski added a comment -

Notes about the supplied pom.xml:

1) I've changed the project version to 1.1.3-SNAPSHOT.
Non-snapshots version numbers should be only reserved for stable teleases (they should only occur on branches and tags in SVN, never in trunk).

2) Relevant dependency numbers, which were too old for the build to succeed, were corrected (these were: maven-cobertura-plugin, maven-findbugs-plugin)

3) All the unit tests seem to run fine:

Results :

Tests run: 694, Failures: 0, Errors: 0, Skipped: 0

[INFO] [jar:jar]
[INFO] Building jar: c:\projekty\3rdparty\jaxen\jaxen-SVN\target\jaxen-1.1.3-SNAPSHOT.jar
[INFO] [install:install]
[INFO] Installing c:\projekty\3rdparty\jaxen\jaxen-SVN\target\jaxen-1.1.3-SNAPSHOT.jar to C:\Documents and Settings\aadamowski\.m2\repository\jaxen\jaxen\1.1.3-SNAPSHOT\jaxen-1.1.3-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7 seconds
[INFO] Finished at: Thu Oct 15 12:45:58 CEST 2009
[INFO] Final Memory: 29M/254M
[INFO] ------------------------------------------------------------------------

Show
Aleksander Adamowski added a comment - Notes about the supplied pom.xml: 1) I've changed the project version to 1.1.3-SNAPSHOT. Non-snapshots version numbers should be only reserved for stable teleases (they should only occur on branches and tags in SVN, never in trunk). 2) Relevant dependency numbers, which were too old for the build to succeed, were corrected (these were: maven-cobertura-plugin, maven-findbugs-plugin) 3) All the unit tests seem to run fine: Results : Tests run: 694, Failures: 0, Errors: 0, Skipped: 0 [INFO] [jar:jar] [INFO] Building jar: c:\projekty\3rdparty\jaxen\jaxen-SVN\target\jaxen-1.1.3-SNAPSHOT.jar [INFO] [install:install] [INFO] Installing c:\projekty\3rdparty\jaxen\jaxen-SVN\target\jaxen-1.1.3-SNAPSHOT.jar to C:\Documents and Settings\aadamowski\.m2\repository\jaxen\jaxen\1.1.3-SNAPSHOT\jaxen-1.1.3-SNAPSHOT.jar [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESSFUL [INFO] ------------------------------------------------------------------------ [INFO] Total time: 7 seconds [INFO] Finished at: Thu Oct 15 12:45:58 CEST 2009 [INFO] Final Memory: 29M/254M [INFO] ------------------------------------------------------------------------
Hide
Permalink
Brian Ewins added a comment -

Attached an updated version of the patch for testing. The previous version wasn't quite correct:

  • the jdom, dom4j, xom dependencies should be optional (see JAXEN-138)
  • the xmlapis/xerces dependencies should be 'provided' (later JREs have these, don't need to impose old xerces version)
  • 'mvn site' didn't work due to missing/misconfigured plugins
  • the linkcheck plugin doesn't exist in m2. (Unfortunately - running it from maven 1 shows we have a bunch of broken links)
  • the issue reporting system needs specified - its JIRA (otherwise reports fail looking for TRAC)
  • the changes plugin needs a commons-codec dependency. At least, on one of my machines it did. This is apparently intermittently reported for that plugin and always ends up being fixed by adding an external dependency.
  • added the assembly plugin, and src-assembly.xml, to simulate the additional artifacts our old maven.xml was creating for 'maven dist'. I /presume/ these are the things we offered for download from sourceforge - is this still necessary? Use "mvn assembly:assembly" to generate these artifacts (XXX-bin.tar.gz, XXX-bin.zip, XXX-src.tar.gz, and XXX-src.zip)
  • fixed a bug that the assembly plugin creates archives containing the full path to your files by depending on an explicit version of this plugin.
  • javadoc plugin was misconfigured, leading to unrecognized '@todo' (the tags configuration block needs to be in the reporting section)
  • source file encoding needs specified to suppress a lot of warning messages in report generation.

Building like this was surprisingly flaky. I tried with IDEA 8.1 (win32), mvn directly (win32, OS X), and Eclipse Ganymede (OS X). Each environment complained slightly differently about missing dependencies.

Hence, I don't think this is ready to land just yet, but worth trying out.

Show
Brian Ewins added a comment - Attached an updated version of the patch for testing. The previous version wasn't quite correct:
  • the jdom, dom4j, xom dependencies should be optional (see JAXEN-138)
  • the xmlapis/xerces dependencies should be 'provided' (later JREs have these, don't need to impose old xerces version)
  • 'mvn site' didn't work due to missing/misconfigured plugins
  • the linkcheck plugin doesn't exist in m2. (Unfortunately - running it from maven 1 shows we have a bunch of broken links)
  • the issue reporting system needs specified - its JIRA (otherwise reports fail looking for TRAC)
  • the changes plugin needs a commons-codec dependency. At least, on one of my machines it did. This is apparently intermittently reported for that plugin and always ends up being fixed by adding an external dependency.
  • added the assembly plugin, and src-assembly.xml, to simulate the additional artifacts our old maven.xml was creating for 'maven dist'. I /presume/ these are the things we offered for download from sourceforge - is this still necessary? Use "mvn assembly:assembly" to generate these artifacts (XXX-bin.tar.gz, XXX-bin.zip, XXX-src.tar.gz, and XXX-src.zip)
  • fixed a bug that the assembly plugin creates archives containing the full path to your files by depending on an explicit version of this plugin.
  • javadoc plugin was misconfigured, leading to unrecognized '@todo' (the tags configuration block needs to be in the reporting section)
  • source file encoding needs specified to suppress a lot of warning messages in report generation.
Building like this was surprisingly flaky. I tried with IDEA 8.1 (win32), mvn directly (win32, OS X), and Eclipse Ganymede (OS X). Each environment complained slightly differently about missing dependencies. Hence, I don't think this is ready to land just yet, but worth trying out.
Hide
Permalink
Brian Ewins added a comment -

Some things were still not working correctly, as all the xdoc and resources needed to be moved to work with the new site plugin; also the old navigation.xml doesn't work any more, so I crafted a new site.xml. This patch can't be applied with svn - it will apply to the master branch of the git repo attached in jaxen-31. (I don't know how to get git to produce svn-compatible patches when there's binary stuff involved - in this case the jaxen logo moved). Stylistically, this appears to be pretty much what we have on the website, except the legend is gone from the bottom of the left hand menu - there doesn't seem to be a way to get that any more.

Also, the checkstyle report had 14000+ errors in it, which wasn't believable. I've added a checkstyle.xml which I believe covers what we used to do in the project.properties, but it still reports 4000+ errors - checkstyle has gained a lot of checks since the version we used.

Show
Brian Ewins added a comment - Some things were still not working correctly, as all the xdoc and resources needed to be moved to work with the new site plugin; also the old navigation.xml doesn't work any more, so I crafted a new site.xml. This patch can't be applied with svn - it will apply to the master branch of the git repo attached in jaxen-31. (I don't know how to get git to produce svn-compatible patches when there's binary stuff involved - in this case the jaxen logo moved). Stylistically, this appears to be pretty much what we have on the website, except the legend is gone from the bottom of the left hand menu - there doesn't seem to be a way to get that any more. Also, the checkstyle report had 14000+ errors in it, which wasn't believable. I've added a checkstyle.xml which I believe covers what we used to do in the project.properties, but it still reports 4000+ errors - checkstyle has gained a lot of checks since the version we used.
Hide
Permalink
Aleksander Adamowski added a comment -

Brian, in my environment the site build (actually site:stage) would fail unless I'd specify the groupIds and stable versions of relevant plugins.

Have a look at attached patch. With those changes applied, jaxen.codehaus.org site gets built properly on my machine in target/staging/jaxen.codehaus.org/home/projects/jaxen/public_html/.

One should specify plugin versions anyway, to make the build repeatable. Also, specifying groupId is a good practice as it sometimes creates problems in resolving plugin dependencies (the site is notorious for that).

Show
Aleksander Adamowski added a comment - Brian, in my environment the site build (actually site:stage) would fail unless I'd specify the groupIds and stable versions of relevant plugins. Have a look at attached patch. With those changes applied, jaxen.codehaus.org site gets built properly on my machine in target/staging/jaxen.codehaus.org/home/projects/jaxen/public_html/. One should specify plugin versions anyway, to make the build repeatable. Also, specifying groupId is a good practice as it sometimes creates problems in resolving plugin dependencies (the site is notorious for that).

People

Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.