JavaNCSS

method arguments that uses generic loses the type in reports

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 32.53
  • Fix Version/s: None
  • Labels:
  • Environment:
    java
  • Number of attachments :
    6

Description

Consider following class.
------------------------------------attached ----------------------------er
public class FlushTestListener implements TestListener{
public static void delete( Collection<? extends Object> toBeDeleted )
{
if ( true )

{ //do }
}
public static void delete( Collection<String> toBeDeleted )
{
if ( true ) { //do }

}
}
----------------------------------
In the complexity report, the name of method arguments are wrong- it lost the collection part.
1 2 2 0 net.sourceforge.cobertura.ant.FlushTestListener.delete(Object)
2 2 2 0 net.sourceforge.cobertura.ant.FlushTestListener.delete(String)

  1. Java Source File
    FlushTestListener.java
    12/Mar/12 12:45 AM
    0.5 kB
    Jayan
  2. Java Source File
    FlushTestListener.java
    27/Dec/11 2:26 AM
    0.5 kB
    Jayan
  4. Text File
    javancss50-type-parameters.patch
    10/Mar/12 5:55 PM
    3 kB
    Yves Martin
  5. Java Source File
    Test0.java
    12/Mar/12 1:00 AM
    0.4 kB
    Jayan
  6. Java Source File
    Test1.java
    12/Mar/12 1:00 AM
    0.5 kB
    Jayan

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Yves Martin added a comment -

Here is a patch to fix parameters parsing to get them better in report. Also the compiled javancss.parser.JavaParser.class for you to patch your jar file.

Show
Yves Martin added a comment - Here is a patch to fix parameters parsing to get them better in report. Also the compiled javancss.parser.JavaParser.class for you to patch your jar file.
Hide
Permalink
Jayan added a comment -

The fix from YVes Martin creates correct output for methods like FlushTestListener.delete(Collection<? extends Object>)
.

This however fails to parse code like below.. (fails at += )

if ( true ) {
//do
int dist=0;
if (dist == 1 || (dist += countNum1s(dist)) > 1)

{ return ; // Not D01 }
Show
Jayan added a comment - The fix from YVes Martin creates correct output for methods like FlushTestListener.delete(Collection<? extends Object>) . This however fails to parse code like below.. (fails at += ) if ( true ) { //do int dist=0; if (dist == 1 || (dist += countNum1s(dist)) > 1) { return ; // Not D01 }
Hide
Permalink
Jayan added a comment -

Different test cases

Show
Jayan added a comment - Different test cases
Hide
Permalink
Yves Martin added a comment -

Here is the compiled jar file from 32.53 sources with patch applied.

Show
Yves Martin added a comment - Here is the compiled jar file from 32.53 sources with patch applied.
Hide
Permalink
Jayan added a comment -

This is working correctly. Great effort.

could you upload the source code changes

Show
Jayan added a comment - This is working correctly. Great effort. could you upload the source code changes

People

  • Assignee:
    Unassigned
    Reporter:
    Jayan
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: