Issue Details (XML | Word | Printable)

Key: JANINO-59
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Arno Unkrig
Reporter: Mo DeJong
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Janino

Patch to stop reporting extra errors

Created: 11/May/06 05:15 PM   Updated: 16/May/06 03:16 PM
Component/s: None
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: 1. Text File errors.patch (1 kB)

Environment: Janino CVS


 Description  « Hide
This patch will avoid the emitter phase when the compile phase sees
a compiler error. There is no point in trying to write out a .class file
when the compiler has already run into an error.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Arno Unkrig added a comment - 16/May/06 03:10 PM
Very good.

In fact, "Compiler" already has something similar ("setStopCompiling()"), but

(A) It does not work properly (you get all kinds of errors from the flow analysis

(B) It is limited to Compiler and does not help with *Evaluator and SimpleCompiler

So I removed "Compiler.setStopCompiling()" and consorts and applied your patch. (I changed the flag to a counter of errors.)

Will be released in version 2.4.4 (not scheduled yet - CODEHAUS CVS is currently down).


Arno Unkrig added a comment - 16/May/06 03:15 PM
Hey, congrats on your first JIRA issue!