Janino

Patch to stop reporting extra errors

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    Janino CVS
  • Number of attachments :
    1

Description

This patch will avoid the emitter phase when the compile phase sees
a compiler error. There is no point in trying to write out a .class file
when the compiler has already run into an error.

Activity

Hide
Arno Unkrig added a comment -

Very good.

In fact, "Compiler" already has something similar ("setStopCompiling()"), but

(A) It does not work properly (you get all kinds of errors from the flow analysis

(B) It is limited to Compiler and does not help with *Evaluator and SimpleCompiler

So I removed "Compiler.setStopCompiling()" and consorts and applied your patch. (I changed the flag to a counter of errors.)

Will be released in version 2.4.4 (not scheduled yet - CODEHAUS CVS is currently down).

Show
Arno Unkrig added a comment - Very good. In fact, "Compiler" already has something similar ("setStopCompiling()"), but (A) It does not work properly (you get all kinds of errors from the flow analysis (B) It is limited to Compiler and does not help with *Evaluator and SimpleCompiler So I removed "Compiler.setStopCompiling()" and consorts and applied your patch. (I changed the flag to a counter of errors.) Will be released in version 2.4.4 (not scheduled yet - CODEHAUS CVS is currently down).
Hide
Arno Unkrig added a comment -

Hey, congrats on your first JIRA issue!

Show
Arno Unkrig added a comment - Hey, congrats on your first JIRA issue!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: