History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: JANINO-101
Type: Bug Bug
Status: Open Open
Priority: Critical Critical
Assignee: Arno Unkrig
Reporter: Arno Unkrig
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Janino

JCI-53: Stack overflow on cross imports in commons-jci-janino

Created: 31/Aug/07 05:47 PM   Updated: 25/Dec/07 03:35 PM
Component/s: None
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified


 Description  « Hide

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Mark Proctor - 21/Sep/07 09:17 PM
the current JCI implementation is not correctly handling all problems, for instance ParseExceptions are being thrown up and not placed into the problems array. I've since added this to the compiler.compile method, but I can't help feeling this should be handled elsewhere. Am I correct in assuming that IOException and CompileException are correctly handled, what about ScanException, is that thrown too without being added to the problems array.

This is what I've added to JaninoJavaCompiler for now.
try { compiler.compile(resources); } catch ( ScanException e ) { problems.add(new JaninoCompilationProblem(e)); // is this already handled? } catch ( ParseException e ) { problems.add(new JaninoCompilationProblem(e)); // we know this isn't handled } catch ( IOException e ) { // I'm hoping the existing compiler problems handler catches these } catch ( CompileException e ) { // I'm hoping the existing compiler problems handler catches these }


Mark Proctor - 21/Sep/07 09:20 PM
sorry with better formatting this time:

This is what I've added to JaninoJavaCompiler for now.

try {
    compiler.compile(resources);
} catch ( ScanException e ) {
    problems.add(new JaninoCompilationProblem(e)); // is this already handled?
} catch ( ParseException e ) {
    problems.add(new JaninoCompilationProblem(e)); // we know this isn't handled 
} catch ( IOException e ) {
    // I'm hoping the existing compiler problems handler catches these            
} catch ( CompileException e ) {
    // I'm hoping the existing compiler problems handler catches these
}

Arno Unkrig - 25/Dec/07 03:35 PM
Ping JCI-53, waiting for reaction.