[#JACKSON-835] @JsonUnwrapped duplicates property with @JsonSerialize or @JsonProperty - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Won't Fix
Affects Version/s: 1.9.2
Fix Version/s: None
Component/s: Serializer
Labels:
None

Number of attachments :
0

Description

 
public static interface Feed {
	public String getTitle();
	public String getCategory();
}

public static class MyFeed implements Feed {
	public String getTitle() {
		return "my title";
	}

	public String getCategory() {
		return "my category";
	}

	public String getAdditionalProperty() {
		return "my new prop";
	}

}

public static class ProxyFeed implements Feed {
	@JsonUnwrapped
	@JsonSerialize or @JsonProperty
	private final Feed feed;

	public ProxyFeed(Feed feed) {
		this.feed = feed;
	}

	public String getTitle() {
		return "Proxy "+ feed.getTitle();
	}
	public String getCategory() {
		return "Proxy " + feed.getCategory();
	}
	
	public String getProxyProperty() {
		return "Proxy new prop";
	}
}

 
System.out.println(new ObjectMapper().writeValueAsString(new ProxyFeed(new MyFeed())));

Output:

{
"category":"my category",
"category":"Proxy my category",
"title":"my title",
"title":"Proxy my title",
"additionalProperty":"my new prop",
"proxyProperty":"Proxy new prop"
}

Output without @JsonSerialize or @JsonProperty for 'feed' in ProxyFeed ("additionalProperty" is missing):

{
"category":"Proxy my category",
"title":"Proxy my title",
"proxyProperty":"Proxy new prop"
}

I Want:

{
"category":"Proxy my category",
"title":"Proxy my title",
"additionalProperty":"my new prop",
"proxyProperty":"Proxy new prop"
}

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tatu Saloranta added a comment - 03/May/12 12:19 PM

What are you trying to do here? I don't quite understand the intent.

I don't think this is a bug – you have two set of properties, one from POJO, trying to add further unwrapped properties. This causes a conflict; and perhaps serializer could try to detect it.

Show

Tatu Saloranta added a comment - 03/May/12 12:19 PM What are you trying to do here? I don't quite understand the intent. I don't think this is a bug – you have two set of properties, one from POJO, trying to add further unwrapped properties. This causes a conflict; and perhaps serializer could try to detect it.

Hide

Permalink

Jongsic Choi added a comment - 07/May/12 1:08 AM

Umm, this is my intention.

Override unwrapped properties value to same name properties of its containing object. In other words, Ignore unwrapped properties when name is conflict. (because json object {} is set)

{"sameName":"unwrapped","sameName":"containing object's value"}

->

{"sameName":"containing object's value"}

is there any way to do this?

Show

Jongsic Choi added a comment - 07/May/12 1:08 AM Umm, this is my intention. Override unwrapped properties value to same name properties of its containing object. In other words, Ignore unwrapped properties when name is conflict. (because json object {} is set) {"sameName":"unwrapped","sameName":"containing object's value"} -> {"sameName":"containing object's value"} is there any way to do this?

Hide

Permalink

Tatu Saloranta added a comment - 07/May/12 12:44 PM

Ok, that makes sense, what you are trying to achieve. Thank you for explanation.
Unfortunately, this will not work with @JsonUnwrapped, so you need to consider alternatives.

I think I would probably try using a custom deserializer. Ideally this might be best done using a post-processing method, if there was a way to add those (in which case you'd be able to add annotation to indicate what to do, without other custom handlers).
But as things are, a custom deserializer might be best way; it could call default deserializer, and then handle merging after this.

One tricky part will be that of locating default deserializer, but a possibly easy way would be to register BeanDeserializerModifier, and in the last callback construct your own deserializer that wraps given default one; and return your own deserializer.

Show

Tatu Saloranta added a comment - 07/May/12 12:44 PM Ok, that makes sense, what you are trying to achieve. Thank you for explanation. Unfortunately, this will not work with @JsonUnwrapped, so you need to consider alternatives. I think I would probably try using a custom deserializer. Ideally this might be best done using a post-processing method, if there was a way to add those (in which case you'd be able to add annotation to indicate what to do, without other custom handlers). But as things are, a custom deserializer might be best way; it could call default deserializer, and then handle merging after this. One tricky part will be that of locating default deserializer, but a possibly easy way would be to register BeanDeserializerModifier, and in the last callback construct your own deserializer that wraps given default one; and return your own deserializer.

@JsonUnwrapped duplicates property with @JsonSerialize or @JsonProperty

Details

Description

Activity

People

Dates