IzPack
  1. IzPack
  2. IZPACK-798

Cannot modify INSTALL_PATH before TargetPanel gets called

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 4.3.5
    • Fix Version/s: 4.3.6, 5.0
    • Component/s: Panels
    • Labels:
      None
    • Environment:
      Linux, Windows,...
    • Patch Submitted:
      Yes
    • Source ID:
      TargetPanelConsoleHelper.java and TargetPanel.java
    • Number of attachments :
      1

      Description

      TargetPanel was modified in order to take variables out of the install definition (Target.dir.os)
      A nice feature would be to allow modifying the target path within user panels called before the target panel. This is impossible right now

      After investigation, I noticed that the code loading the variables out of the install.xml file is called through the constructor.

      Instead, I propose to call that code through the panelActivated() method which was created for this purpose

      I issued a patch with this issue. I tested the patch which works

      • created a user panel that let the user select some kind of "target environment" ie development or production
      • that panel is the first to be called
      • modified installer.xml so the TargetPanel.dir variable is using the variable defined in the first user panel
      • tested the installer, the default install directory changes as expected

        Activity

        Hide
        Fabien Nisol added a comment -

        diff -r -w -u jponge-izpack-4.3.5 jponge-izpack-4.3.5-hq > patch.txt

        Show
        Fabien Nisol added a comment - diff -r -w -u jponge-izpack-4.3.5 jponge-izpack-4.3.5-hq > patch.txt
        Hide
        Julien Ponge added a comment -

        Fixed, thanks.

        Show
        Julien Ponge added a comment - Fixed, thanks.
        Hide
        Tim Anderson added a comment -

        Change needs to be applied to 5.0

        Show
        Tim Anderson added a comment - Change needs to be applied to 5.0
        Hide
        Tim Anderson added a comment -
        Show
        Tim Anderson added a comment - Pull request is: https://github.com/izpack/izpack/pull/37

          People

          • Assignee:
            Tim Anderson
            Reporter:
            Fabien Nisol
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 day
              1d
              Remaining:
              Remaining Estimate - 1 day
              1d
              Logged:
              Time Spent - Not Specified
              Not Specified