IzPack

Make PanelAction and Panel configuration <param> tags consistent with equivalent in installer <guiprefs> and UserInputPanel <validator>

Details

  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

Currently, the optional (and undocumented) <param> tag for a panel <action> uses nested elements to define a key and a value. The similarly undocumented <configuration> tag for a panel also takes a <param> tag in this form. These should be changed to use the name/value attributes common to the other, documented <param> tags in the installation descriptor and UserInputPanel descriptor, and the whole lot should be documented. The changes should also be documented in the Upgrading from Previous Versions wiki page.

There are no PanelAction implementations in the IzPack distribution, nor any panels that use the <configuration> tag. These changes, then, affect only third-party extensions for IzPack. This change for the PanelAction <param> was previously mooted in IZPACK-791.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel Abson added a comment -

The patch also removes a redundant null-check in the CompilerConfig code that parses the panel <configuration> tag, and add integration tests for both changes.

Show
Daniel Abson added a comment - The patch also removes a redundant null-check in the CompilerConfig code that parses the panel <configuration> tag, and add integration tests for both changes.
Hide
Permalink
Daniel Abson added a comment -

I'm happy to update the new documentation with this information, by the way. I guess that would be best done after the release of the next beta?

Show
Daniel Abson added a comment - I'm happy to update the new documentation with this information, by the way. I guess that would be best done after the release of the next beta?
Hide
Permalink
Tim Anderson added a comment -

You might as well add it now, with a note that it isn't released yet. That way its less likely to be forgotten.

There's a few minor issues:

  • CompilerConfigMockedTest.shouldAddPanelConfiguration() is incomplete
  • panelactions.xml has the key/value configuration instead of name/value
Show
Tim Anderson added a comment - You might as well add it now, with a note that it isn't released yet. That way its less likely to be forgotten. There's a few minor issues: CompilerConfigMockedTest.shouldAddPanelConfiguration() is incomplete panelactions.xml has the key/value configuration instead of name/value
Hide
Permalink
Daniel Abson added a comment -

New patch fixes the integration tests. I've updated the documentation as well, with warning boxes that can be removed after 5.0.0-beta11 is released.

Show
Daniel Abson added a comment - New patch fixes the integration tests. I've updated the documentation as well, with warning boxes that can be removed after 5.0.0-beta11 is released.
Hide
Permalink
Tim Anderson added a comment -

Changes applied thanks.

Show
Tim Anderson added a comment - Changes applied thanks.

People

  • Assignee:
    Tim Anderson
    Reporter:
    Daniel Abson
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: