|
Julien Ponge made changes - 23/Apr/08 05:45 PM
Dennis Reil made changes - 24/Apr/08 01:01 AM
Dennis Reil made changes - 24/Apr/08 01:47 AM
Hi. Only one thing. I think the DynamicVariable's equals/hascode should be depended only on name and condition fields.
Pavol Zibrita made changes - 24/Apr/08 03:16 AM
Will there be some 3.12 with this fix? using value and conditionid for the hashcode is more general as these are the variables which can be different. There will be no fix for 3.11.
Dennis Reil made changes - 24/Apr/08 04:06 AM
Just my last 2 cents than: As this code in CompilerConfig is depended on DynamicVariable equals implementation: if (dynamicValues.remove(dynamicVariable)){ parseWarn(var, "Dynamic Variable '" + name + "' will be overwritten"); } for current implementation b) is the overwritte. Should not it be the a)? This seems to be a mistake, but you will be not warned: Anyway, thanks for implementing it! good and fast work ok, your example convinced me Thanks for your comments on that!
Thanks for all! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
I did not apply the patch, but changed the behaviour to the support of multiple values with different conditions.