|
|
|
[
Permlink
| « Hide
]
Dennis Reil - 24/Apr/08 01:47 AM
I did not apply the patch, but changed the behaviour to the support of multiple values with different conditions.
Hi. Only one thing. I think the DynamicVariable's equals/hascode should be depended only on name and condition fields.
using value and conditionid for the hashcode is more general as these are the variables which can be different.
There will be no fix for 3.11. Just my last 2 cents than:
What is then a "Dynamic variable overwritte?". a) when you create a variable with same name and same condition but different value? b) when you create a variable with same name, same condition and same value? As this code in CompilerConfig is depended on DynamicVariable equals implementation: if (dynamicValues.remove(dynamicVariable)){ parseWarn(var, "Dynamic Variable '" + name + "' will be overwritten"); } for current implementation b) is the overwritte. Should not it be the a)? This seems to be a mistake, but you will be not warned: Anyway, thanks for implementing it! good and fast work ok, your example convinced me
I changed the hashCode() implementation. Thanks for your comments on that! Thanks for all! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||