IzPack
  1. IzPack
  2. IZPACK-658

ShortcutPanel crashes on page flipping

    Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 4.3.3
    • Fix Version/s: None
    • Component/s: Panels
    • Labels:
      None
    • Environment:
      Windows 7 x64
    • Number of attachments :
      1

      Description

      Create an install like this.

      <listeners>
      <listener installer="LateShortcutInstallListener" />
      </listeners>

      <panel classname="CheckedHelloPanel"/>
      <panel classname="LicencePanel"/>
      <panel classname="TargetPanel"/>
      <panel classname="PacksPanel"/>
      <panel classname="ShortcutPanel"/>
      <panel classname="SummaryPanel"/>
      <panel classname="InstallPanel"/>
      <panel classname="SimpleFinishPanel"/>

      When you reach ShortcutPanel press back and then next.
      The panel will not show correctly and the following stacktrace is provided

      java.lang.Exception: could not get an instance of IShellLink, failed to co-create instance
      at com.izforge.izpack.util.os.ShellLink.initialize(ShellLink.java:536)
      at com.izforge.izpack.util.os.ShellLink.<init>(ShellLink.java:374)
      at com.izforge.izpack.util.os.Win_Shortcut.initialize(Win_Shortcut.java:82)
      at com.izforge.izpack.panels.ShortcutPanel.panelActivate(ShortcutPanel.java:812)
      at com.izforge.izpack.installer.InstallerFrame.switchPanel(InstallerFrame.java:839)
      at com.izforge.izpack.installer.InstallerFrame.navigateNext(InstallerFrame.java:1451)
      at com.izforge.izpack.installer.InstallerFrame.navigateNext(InstallerFrame.java:1419)
      at com.izforge.izpack.installer.InstallerFrame$NavigationHandler.navigate(InstallerFrame.java:1582)
      at com.izforge.izpack.installer.InstallerFrame$NavigationHandler.access$0(InstallerFrame.java:1577)
      at com.izforge.izpack.installer.InstallerFrame$NavigationHandler$1.run(InstallerFrame.java:1566)
      at java.lang.Thread.run(Unknown Source)

      java.lang.NullPointerException
      at com.izforge.izpack.util.os.Win_Shortcut.getProgramsFolder(Win_Shortcut.java:679)
      at com.izforge.izpack.panels.ShortcutPanel.getProgramsFolder(ShortcutPanel.java:915)
      at com.izforge.izpack.panels.ShortcutPanel.panelActivate(ShortcutPanel.java:826)
      at com.izforge.izpack.installer.InstallerFrame.switchPanel(InstallerFrame.java:839)
      at com.izforge.izpack.installer.InstallerFrame.navigateNext(InstallerFrame.java:1451)
      at com.izforge.izpack.installer.InstallerFrame.navigateNext(InstallerFrame.java:1419)
      at com.izforge.izpack.installer.InstallerFrame$NavigationHandler.navigate(InstallerFrame.java:1582)
      at com.izforge.izpack.installer.InstallerFrame$NavigationHandler.access$0(InstallerFrame.java:1577)
      at com.izforge.izpack.installer.InstallerFrame$NavigationHandler$1.run(InstallerFrame.java:1566)
      at java.lang.Thread.run(Unknown Source)

      Maybe only checking for shortcut field not initialized solves the problem, but I didn't go that far in finding what is causing the problem.

        Activity

        Hide
        Markus Schlegel added a comment -

        Same problem here. I am using IzPack 4.3.3 on Windows 7 64-bit, but using a 32-bit JRE (therefore os.arch is x86).
        Same Problem occurred on Windows Vista, 32-bit.

        Show
        Markus Schlegel added a comment - Same problem here. I am using IzPack 4.3.3 on Windows 7 64-bit, but using a 32-bit JRE (therefore os.arch is x86). Same Problem occurred on Windows Vista, 32-bit.
        Hide
        &#321;ukasz Kuczera added a comment -

        Same problem appears in 4.3.5

        Show
        &#321;ukasz Kuczera added a comment - Same problem appears in 4.3.5
        Hide
        Sreram Balasubramaniyan added a comment -

        Any updates for this bug? Its been more than a year and this bug is yet unresolved.

        I get the same problem in 4.3.5 on Windows. Linux to be tested but no hope in believing this bug will not occur in Linux.

        Show
        Sreram Balasubramaniyan added a comment - Any updates for this bug? Its been more than a year and this bug is yet unresolved. I get the same problem in 4.3.5 on Windows. Linux to be tested but no hope in believing this bug will not occur in Linux.
        Hide
        Christoph Panwinkler added a comment - - edited

        I've attached a patch for 4.3.5 that works for me on Windows 7 x64.

        Shortcut is just initialized in a static context, so I guess if Shortcuts are used in ShortcutPanel only the patch would be sufficient

        Show
        Christoph Panwinkler added a comment - - edited I've attached a patch for 4.3.5 that works for me on Windows 7 x64. Shortcut is just initialized in a static context, so I guess if Shortcuts are used in ShortcutPanel only the patch would be sufficient
        Hide
        Rene Krell added a comment - - edited

        Seems like no one of the original maintainers of the IzPack 4 branch is currently active. Will have a look at the state of the IzPack 4 branch next time, hopefully, but personally I do not intend to spent too much time with it. There is too much work with the 5.0. So this is also a call in the wild, whether there is still someone listening who initiated or maintained the IzPack 4 branch some time ago. A sent patch is worth at least checking it.

        Can you please check whether this applies also on IzPack 5.0.0 >= beta11, thus whether it is reproducable and the patch fixes it also there?
        I'm not sure whether the same OS conditions apply on the virtual test machine of Win 7 I have available and your one.

        Show
        Rene Krell added a comment - - edited Seems like no one of the original maintainers of the IzPack 4 branch is currently active. Will have a look at the state of the IzPack 4 branch next time, hopefully, but personally I do not intend to spent too much time with it. There is too much work with the 5.0. So this is also a call in the wild, whether there is still someone listening who initiated or maintained the IzPack 4 branch some time ago. A sent patch is worth at least checking it. Can you please check whether this applies also on IzPack 5.0.0 >= beta11, thus whether it is reproducable and the patch fixes it also there? I'm not sure whether the same OS conditions apply on the virtual test machine of Win 7 I have available and your one.
        Hide
        Christoph Panwinkler added a comment - - edited

        ShortcutPanel works out of the box with IzPack 5.0.0-beta11, so nothing to do with IzPack 5.

        Show
        Christoph Panwinkler added a comment - - edited ShortcutPanel works out of the box with IzPack 5.0.0-beta11, so nothing to do with IzPack 5.

          People

          • Assignee:
            Unassigned
            Reporter:
            Marcelo Marzola Bossoni
          • Votes:
            4 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated: