IzPack
  1. IzPack
  2. IZPACK-637

JDKPathPanel does not work in automated mode

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.3.3
    • Fix Version/s: 4.3.4, 5.0
    • Component/s: Installer
    • Labels:
      None
    • Number of attachments :
      0

      Description

      needs a JDKPathPanelAutomationHelper

        Activity

        Show
        Mark Miller added a comment - A simple untested impl: https://github.com/lucidimagination/izpack/commit/34b0d0029ffdc7e5f85c624da8084f81e7aeab72
        Show
        Mark Miller added a comment - tested impl: https://github.com/lucidimagination/izpack/commit/06a1d16f7a7e6446463b53b10940a933f4c059da
        Hide
        Stuart Wallis added a comment -

        The final line of the JDKPathPanelAutomationHelper at github will overwrite the INSTALL_PATH variable. I think you should use this instead:

        idata.setVariable(JDK_PATH, jdkPath);

        Show
        Stuart Wallis added a comment - The final line of the JDKPathPanelAutomationHelper at github will overwrite the INSTALL_PATH variable. I think you should use this instead: idata.setVariable(JDK_PATH, jdkPath);
        Hide
        Mark Miller added a comment -

        Thanks for the review Stuart!

        Fixed that one yesterday (can't remember who emailed me to point it out): https://github.com/lucidimagination/izpack/commit/ad81d5f4fd5bee68b07d3c3d9ccb6ced2a445ff0

        I had tested that it wrote the xml and then ran fine after - but not what actually got read from the xml. Copy paste bug from the target panel automation class.

        Show
        Mark Miller added a comment - Thanks for the review Stuart! Fixed that one yesterday (can't remember who emailed me to point it out): https://github.com/lucidimagination/izpack/commit/ad81d5f4fd5bee68b07d3c3d9ccb6ced2a445ff0 I had tested that it wrote the xml and then ran fine after - but not what actually got read from the xml. Copy paste bug from the target panel automation class.

          People

          • Assignee:
            Julien Ponge
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: