IzPack
  1. IzPack
  2. IZPACK-610

FinishPanel has hardcoded path for Uninstaller location

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.4, 5.0
    • Component/s: Installer
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Say you change the installer dir, or even just make it uninstaller rather than Uninstaller:

      <uninstaller name="uninstaller.jar" path="$INSTALL_PATH/uninstaller"/>

      FinishPanel doesn't respect that when it tells the user where to find the uninstaller:

      // We prepare a message for the uninstaller feature
      String path = translatePath("$INSTALL_PATH") + File.separator + "Uninstaller";

      Instead, it should pick up the correct uninstaller path.

        Activity

        Hide
        Mark Miller added a comment -

        Say you change the installer dir

        should be:

        Say you change the uninstaller dir

        Show
        Mark Miller added a comment - Say you change the installer dir should be: Say you change the uninstaller dir
        Hide
        Mark Miller added a comment -
        Show
        Mark Miller added a comment - I have made a fix for this off 4.3.3 here: https://github.com/lucidimagination/izpack/commit/418de508a67a14dfc7413ddb319c7418c0c18664
        Hide
        Julien Ponge added a comment -

        I am closing since that was merged.

        Show
        Julien Ponge added a comment - I am closing since that was merged.

          People

          • Assignee:
            Julien Ponge
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: