Issue Details (XML | Word | Printable)

Key: IZPACK-59
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Julien Ponge
Reporter: Benjamin Bentmann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
IzPack

Fix display of localized pack names in PackPanel

Created: 13/Apr/08 03:07 PM   Updated: 23/Apr/08 02:02 PM   Resolved: 19/Apr/08 03:27 PM
Return to search
Component/s: Installer
Affects Version/s: 3.11.0
Fix Version/s: 4.0.0

Time Tracking:
Not Specified

File Attachments: 1. Text File localized-pack-name.patch (1 kB)


Patch Submitted: Yes


 Description  « Hide

The fix for r1858 is too simplistic. If the localized pack name happens to equal the pack id, you return (the unlocalized) pack.name but who said that the pack name from the installer script matches the requested locale? For example, assume pack.id = "SVG-Support", pack.name = "SVG-Unterstützung" and pack.name.eng = "SVG-Support". Requesting the pack name for the locale "eng" will erroneously return "SVG-Unterstützung" in this case because the code misinterprets pack.id == pack.name.locale as a missing string value.

If the code wants to test for undefined keys, the method LocaleDatabase.getString() is the wrong choice.



Julien Ponge added a comment - 23/Apr/08 02:02 PM

The issue is confirmed to be closed.