IzPack

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.11.0
• Fix Version/s: 4.0.0
• Component/s: Installer
• Labels:

  None

The fix for r1858 is too simplistic. If the localized pack name happens to equal the pack id, you return (the unlocalized) pack.name but who said that the pack name from the installer script matches the requested locale? For example, assume pack.id = "SVG-Support", pack.name = "SVG-Unterstützung" and pack.name.eng = "SVG-Support". Requesting the pack name for the locale "eng" will erroneously return "SVG-Unterstützung" in this case because the code misinterprets pack.id == pack.name.locale as a missing string value.

If the code wants to test for undefined keys, the method LocaleDatabase.getString() is the wrong choice.

1. 

   localized-pack-name.patch

   13/Apr/08 3:07 PM

   1 kB

   Benjamin Bentmann

• Assignee:

  Julien Ponge

  Reporter:

  Benjamin Bentmann

• Created:

  13/Apr/08 3:07 PM

  Updated:

  23/Apr/08 2:02 PM

  Resolved:

  19/Apr/08 3:27 PM