Issue Details (XML | Word | Printable)

Key: IZPACK-57
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Julien Ponge
Reporter: Benjamin Bentmann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
IzPack

User installation fails with enabled registry support

Created: 12/Apr/08 05:50 PM   Updated: 23/Apr/08 02:02 PM   Resolved: 19/Apr/08 03:19 PM
Return to search
Component/s: Installer
Affects Version/s: 3.11.0
Fix Version/s: 4.0.0

Time Tracking:
Not Specified

File Attachments: 1. Text File registry-uninstall.patch (2 kB)
Environment: Windows

Patch Submitted: Yes


 Description  « Hide

On Windows, a non-admin user can still install applications for his personal usage. When the registry uninstall support has been enabled for IzPack, such a user installation fails: IzPack will abort the entire installation when the registry write access to HKLM\..\Uninstall is rejected due to the missing admin rights.

The attached patch falls back to HKCU\..\Uninstall in those cases, allowing the installation to succeed and register the uninstaller in the "Add/Remove programs" control panel for the current user.

Furthermore, the patch writes the additiional key "DisplayVersion" and "HelpLink" to the registry to improve user experience. See also Uninstall Registry Key.

Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Benjamin Bentmann added a comment - 12/Apr/08 05:54 PM

The patch uses hard-coded string literals to access installer data like demonstrated by other code in the class. If there is no particular reason for using string literals, it might be advisiable to reuse the string constants from ScriptParser.


[ Permalink | « Hide ]
Julien Ponge added a comment - 13/Apr/08 02:41 PM

Will be reviewed for inclusion in 4.0.0


Julien Ponge made changes - 13/Apr/08 02:41 PM
Field Original Value New Value
Fix Version/s 4.0.0 [ 14071 ]
Julien Ponge made changes - 19/Apr/08 03:14 PM
Assignee Julien Ponge [ jponge ]
[ Permalink | « Hide ]
Julien Ponge added a comment - 19/Apr/08 03:19 PM

Just merged, thanks for the patch!


Julien Ponge made changes - 19/Apr/08 03:19 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Julien Ponge added a comment - 23/Apr/08 02:02 PM

The issue is confirmed to be closed.


Julien Ponge made changes - 23/Apr/08 02:02 PM
Status Resolved [ 5 ] Closed [ 6 ]
Atlassian JIRA (v4.0#466) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.