IzPack

User installation fails with enabled registry support

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.11.0
  • Fix Version/s: 4.0.0
  • Component/s: Installer
  • Labels:
    None
  • Environment:
    Windows
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

On Windows, a non-admin user can still install applications for his personal usage. When the registry uninstall support has been enabled for IzPack, such a user installation fails: IzPack will abort the entire installation when the registry write access to HKLM\..\Uninstall is rejected due to the missing admin rights.

The attached patch falls back to HKCU\..\Uninstall in those cases, allowing the installation to succeed and register the uninstaller in the "Add/Remove programs" control panel for the current user.

Furthermore, the patch writes the additiional key "DisplayVersion" and "HelpLink" to the registry to improve user experience. See also Uninstall Registry Key.

Activity

Hide
Benjamin Bentmann added a comment -

The patch uses hard-coded string literals to access installer data like demonstrated by other code in the class. If there is no particular reason for using string literals, it might be advisiable to reuse the string constants from ScriptParser.

Show
Benjamin Bentmann added a comment - The patch uses hard-coded string literals to access installer data like demonstrated by other code in the class. If there is no particular reason for using string literals, it might be advisiable to reuse the string constants from ScriptParser.
Hide
Julien Ponge added a comment -

Will be reviewed for inclusion in 4.0.0

Show
Julien Ponge added a comment - Will be reviewed for inclusion in 4.0.0
Hide
Julien Ponge added a comment -

Just merged, thanks for the patch!

Show
Julien Ponge added a comment - Just merged, thanks for the patch!
Hide
Julien Ponge added a comment -

The issue is confirmed to be closed.

Show
Julien Ponge added a comment - The issue is confirmed to be closed.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: