[#IZPACK-479] Missing classes in release 4.3.1 - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 4.3.1
Fix Version/s: 4.3.2, 4.3.3, 5.0
Component/s: Panels
Labels:
None

Number of attachments :
0

Description

Lots of classes are missing in IzPack-install-4.3.1.jar (both in official site: http://izpack.org/downloads/ or maven repository: http://repo1.maven.org/maven2/org/codehaus/izpack/izpack-standalone-compiler/4.3.1/).

For axample, if you compare the panels source code (http://svn.codehaus.org/izpack/izpack-src/tags/4.3.1/src/lib/com/izforge/izpack/panels/) and the panels classes inside official jar files, you can see that some classes like com.izforge.izpack.panels.Processor are missing.

This is a blocker issue since we can't use these classes to develop custom components. For example, it's not possible to create custom Processor classes to set default value inside UserInputPanel (userInputSpec.xml):
<userInput>
<panel order="0">
<field ...
<spec txt="Enter IP address of ${application.server.name}:"
layout="N:3:3 . N:3:3 . N:3:3 . N:3:3"
set="0:defaultVal:ServerIpProcessor 1:defaultVal:ServerIpProcessor 2:defaultVal:ServerIpProcessor 3:defaultVal:ServerIpProcessor"
resultFormat="displayFormat" />
...

This is one of the examples...

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Julien Ponge added a comment - 06/Nov/09 3:18 AM

Fixed in IzPack 4.3.2 (to be released today).

infinity:src jponge$ unzip -t ../bin/panels/UserInputPanel.jar 
Archive:  ../bin/panels/UserInputPanel.jar
    testing: META-INF/                OK
    testing: META-INF/MANIFEST.MF     OK
    testing: com/                     OK
    testing: com/izforge/             OK
    testing: com/izforge/izpack/      OK
    testing: com/izforge/izpack/panels/   OK
    testing: com/izforge/izpack/panels/DirInputField.class   OK
    testing: com/izforge/izpack/panels/FileInputField.class   OK
    testing: com/izforge/izpack/panels/MultipleFileInputField.class   OK
    testing: com/izforge/izpack/panels/PasswordGroup.class   OK
    testing: com/izforge/izpack/panels/PasswordUIElement.class   OK
    testing: com/izforge/izpack/panels/ProcessingClient.class   OK
    testing: com/izforge/izpack/panels/Processor.class   OK
    testing: com/izforge/izpack/panels/RadioButtonUIElement.class   OK
    testing: com/izforge/izpack/panels/RuleInputField$FieldSpec.class   OK
    testing: com/izforge/izpack/panels/RuleInputField.class   OK
    testing: com/izforge/izpack/panels/RuleTextField$Rule.class   OK
    testing: com/izforge/izpack/panels/RuleTextField.class   OK
    testing: com/izforge/izpack/panels/StringInputProcessingClient.class   OK
    testing: com/izforge/izpack/panels/TextInputField.class   OK
    testing: com/izforge/izpack/panels/UIElement.class   OK
    testing: com/izforge/izpack/panels/UIElementType.class   OK
    testing: com/izforge/izpack/panels/UserInputFileFilter.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel$SearchField$1.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel$SearchField.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel$TextValuePair.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelAutomationHelper.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper$Choice.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper$Input.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper$Password.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper.class   OK
    testing: com/izforge/izpack/panels/Validator.class   OK
    testing: com/izforge/izpack/panels/ValidatorContainer.class   OK
No errors detected in compressed data of ../bin/panels/UserInputPanel.jar.

Show

Julien Ponge added a comment - 06/Nov/09 3:18 AM Fixed in IzPack 4.3.2 (to be released today).

infinity:src jponge$ unzip -t ../bin/panels/UserInputPanel.jar 
Archive:  ../bin/panels/UserInputPanel.jar
    testing: META-INF/                OK
    testing: META-INF/MANIFEST.MF     OK
    testing: com/                     OK
    testing: com/izforge/             OK
    testing: com/izforge/izpack/      OK
    testing: com/izforge/izpack/panels/   OK
    testing: com/izforge/izpack/panels/DirInputField.class   OK
    testing: com/izforge/izpack/panels/FileInputField.class   OK
    testing: com/izforge/izpack/panels/MultipleFileInputField.class   OK
    testing: com/izforge/izpack/panels/PasswordGroup.class   OK
    testing: com/izforge/izpack/panels/PasswordUIElement.class   OK
    testing: com/izforge/izpack/panels/ProcessingClient.class   OK
    testing: com/izforge/izpack/panels/Processor.class   OK
    testing: com/izforge/izpack/panels/RadioButtonUIElement.class   OK
    testing: com/izforge/izpack/panels/RuleInputField$FieldSpec.class   OK
    testing: com/izforge/izpack/panels/RuleInputField.class   OK
    testing: com/izforge/izpack/panels/RuleTextField$Rule.class   OK
    testing: com/izforge/izpack/panels/RuleTextField.class   OK
    testing: com/izforge/izpack/panels/StringInputProcessingClient.class   OK
    testing: com/izforge/izpack/panels/TextInputField.class   OK
    testing: com/izforge/izpack/panels/UIElement.class   OK
    testing: com/izforge/izpack/panels/UIElementType.class   OK
    testing: com/izforge/izpack/panels/UserInputFileFilter.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel$SearchField$1.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel$SearchField.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel$TextValuePair.class   OK
    testing: com/izforge/izpack/panels/UserInputPanel.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelAutomationHelper.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper$Choice.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper$Input.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper$Password.class   OK
    testing: com/izforge/izpack/panels/UserInputPanelConsoleHelper.class   OK
    testing: com/izforge/izpack/panels/Validator.class   OK
    testing: com/izforge/izpack/panels/ValidatorContainer.class   OK
No errors detected in compressed data of ../bin/panels/UserInputPanel.jar.

Hide

Permalink

Julien Ponge added a comment - 14/Nov/09 4:41 PM

The classes need to be added to the standalone compiler JAR.

Show

Julien Ponge added a comment - 14/Nov/09 4:41 PM The classes need to be added to the standalone compiler JAR.

Hide

Permalink

Julien Ponge added a comment - 16/Nov/09 1:46 AM

The standalone compiler will now have all IzPack classes.

The fix will appear soon in another maintenance release (4.3.3).

Show

Julien Ponge added a comment - 16/Nov/09 1:46 AM The standalone compiler will now have all IzPack classes. The fix will appear soon in another maintenance release (4.3.3).

Hide

Permalink

Mitchel added a comment - 11/Jan/10 7:17 AM

Same issue appears with 4.3.3 release

Show

Mitchel added a comment - 11/Jan/10 7:17 AM Same issue appears with 4.3.3 release

Hide

Permalink

Julien Ponge added a comment - 25/Jan/10 2:12 AM

I checked 4.3.3 and the processor / validator classes are in:

infinity:src jponge$ unzip -t ../_dist/IzPack-install-4.3.3.jar  | grep Validator
    testing: com/izforge/izpack/installer/DataValidator$Status.class   OK
    testing: com/izforge/izpack/installer/DataValidator.class   OK
    testing: com/izforge/izpack/installer/DataValidatorFactory.class   OK
    testing: com/izforge/izpack/installer/PackValidator.class   OK
    testing: com/izforge/izpack/panels/Validator.class   OK
    testing: com/izforge/izpack/panels/ValidatorContainer.class   OK
    testing: com/izforge/izpack/util/HostAddressValidator.class   OK
    testing: com/izforge/izpack/util/IsPortValidator.class   OK
    testing: com/izforge/izpack/util/NotEmptyValidator.class   OK
    testing: com/izforge/izpack/util/PasswordEncryptionValidator.class   OK
    testing: com/izforge/izpack/util/PasswordEqualityValidator.class   OK
    testing: com/izforge/izpack/util/PasswordKeystoreValidator.class   OK
    testing: com/izforge/izpack/util/PortValidator.class   OK
    testing: com/izforge/izpack/util/RegularExpressionValidator.class   OK
infinity:src jponge$ unzip -t ../_dist/IzPack-install-4.3.3.jar  | grep Processor
    testing: com/izforge/izpack/util/PortProcessor.class   OK
    testing: com/izforge/izpack/util/SummaryProcessor.class   OK
    testing: com/izforge/izpack/util/UnixGroupProcessor.class   OK
    testing: com/izforge/izpack/util/UnixUserProcessor.class   OK

Unless you mention which classes are missing, I will close the issue again.

Show

Julien Ponge added a comment - 25/Jan/10 2:12 AM I checked 4.3.3 and the processor / validator classes are in:

infinity:src jponge$ unzip -t ../_dist/IzPack-install-4.3.3.jar  | grep Validator
    testing: com/izforge/izpack/installer/DataValidator$Status.class   OK
    testing: com/izforge/izpack/installer/DataValidator.class   OK
    testing: com/izforge/izpack/installer/DataValidatorFactory.class   OK
    testing: com/izforge/izpack/installer/PackValidator.class   OK
    testing: com/izforge/izpack/panels/Validator.class   OK
    testing: com/izforge/izpack/panels/ValidatorContainer.class   OK
    testing: com/izforge/izpack/util/HostAddressValidator.class   OK
    testing: com/izforge/izpack/util/IsPortValidator.class   OK
    testing: com/izforge/izpack/util/NotEmptyValidator.class   OK
    testing: com/izforge/izpack/util/PasswordEncryptionValidator.class   OK
    testing: com/izforge/izpack/util/PasswordEqualityValidator.class   OK
    testing: com/izforge/izpack/util/PasswordKeystoreValidator.class   OK
    testing: com/izforge/izpack/util/PortValidator.class   OK
    testing: com/izforge/izpack/util/RegularExpressionValidator.class   OK
infinity:src jponge$ unzip -t ../_dist/IzPack-install-4.3.3.jar  | grep Processor
    testing: com/izforge/izpack/util/PortProcessor.class   OK
    testing: com/izforge/izpack/util/SummaryProcessor.class   OK
    testing: com/izforge/izpack/util/UnixGroupProcessor.class   OK
    testing: com/izforge/izpack/util/UnixUserProcessor.class   OK

Unless you mention which classes are missing, I will close the issue again.

Hide

Permalink

Mitchel added a comment - 25/Jan/10 3:08 AM

As mentionned at the beginning, Processor interface IS in the source repository (http://svn.codehaus.org/izpack/izpack-src/tags/4.3.3/src/lib/com/izforge/izpack/panels/) but NOT in the jar file, as you can see from your unzip command.

Also, as Dan mentionned before in this thread, I'm using izpack-maven-plugin which requires every thing in the standalone compiler. For the last 4.3.3 release, I can't find the good repository (http://repo1.maven.org/maven2/org/codehaus/izpack/izpack-standalone-compiler/ is not updated).

Show

Mitchel added a comment - 25/Jan/10 3:08 AM As mentionned at the beginning, Processor interface IS in the source repository (http://svn.codehaus.org/izpack/izpack-src/tags/4.3.3/src/lib/com/izforge/izpack/panels/) but NOT in the jar file, as you can see from your unzip command. Also, as Dan mentionned before in this thread, I'm using izpack-maven-plugin which requires every thing in the standalone compiler. For the last 4.3.3 release, I can't find the good repository (http://repo1.maven.org/maven2/org/codehaus/izpack/izpack-standalone-compiler/ is not updated).

Hide

Permalink

Julien Ponge added a comment - 25/Jan/10 3:13 AM

My bad. I see now.

Show

Julien Ponge added a comment - 25/Jan/10 3:13 AM My bad. I see now.

Hide

Permalink

Julien Ponge added a comment - 25/Jan/10 3:20 AM

Fixed.

Show

Julien Ponge added a comment - 25/Jan/10 3:20 AM Fixed.

Hide

Permalink

Mitchel added a comment - 26/Jan/10 10:08 AM - edited

Processor interface still not in the jar:

 
unzip -t IzPack-install-4.3.3.jar | grep Processor
    testing: com/izforge/izpack/util/PortProcessor.class   OK
    testing: com/izforge/izpack/util/SummaryProcessor.class   OK
    testing: com/izforge/izpack/util/UnixGroupProcessor.class   OK
    testing: com/izforge/izpack/util/UnixUserProcessor.class   OK

Show

Mitchel added a comment - 26/Jan/10 10:08 AM - edited Processor interface still not in the jar:

 
unzip -t IzPack-install-4.3.3.jar | grep Processor
    testing: com/izforge/izpack/util/PortProcessor.class   OK
    testing: com/izforge/izpack/util/SummaryProcessor.class   OK
    testing: com/izforge/izpack/util/UnixGroupProcessor.class   OK
    testing: com/izforge/izpack/util/UnixUserProcessor.class   OK

Hide

Permalink

Julien Ponge added a comment - 26/Jan/10 11:13 AM

Of course, this will appear only in the next release.

You can still grab the SVN trunk and build an installer as an emergency fix.

Show

Julien Ponge added a comment - 26/Jan/10 11:13 AM Of course, this will appear only in the next release. You can still grab the SVN trunk and build an installer as an emergency fix.

People

Assignee:

Julien Ponge

Reporter:

Mitchel

Vote (0)

Watch (1)

Dates

Created:

06/Nov/09 3:08 AM

Updated:

26/Jan/10 11:13 AM

Resolved:

26/Jan/10 11:13 AM