IzPack
  1. IzPack
  2. IZPACK-472

Handling of elements and their attributes is not fully implemented in UserInputPanelConsoleHelper

    Details

    • Type: Bug Bug
    • Status: In Progress In Progress
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 5.0
    • Component/s: Panels
    • Labels:
      None
    • Number of attachments :
      0

      Description

      The UserInputPanelConsoleHelper does currently not support all fields and options available in the standard UserInputPanel. Furthermore, it implements a second analysis of the xml structure.

      This has to be refactored to only use one analysis and to support the same elements, attributes, ...

        Activity

        Julien Ponge made changes -
        Field Original Value New Value
        Fix Version/s 4.3.2 [ 15381 ]
        Hide
        martin krueger added a comment -

        Hi Dennis,
        are you already working on this? I started about a week ago but unfortunatly I cannot assign anything to my name.
        Greetings,
        Martin

        Show
        martin krueger added a comment - Hi Dennis, are you already working on this? I started about a week ago but unfortunatly I cannot assign anything to my name. Greetings, Martin
        Tim Anderson made changes -
        Assignee Dennis Reil [ dreil ] Tim Anderson [ tima ]
        Tim Anderson made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Tim Anderson added a comment -
        Show
        Tim Anderson added a comment - Started work on this at https://github.com/unb/izpack/tree/IZPACK-472
        Hide
        Rene Krell added a comment - - edited

        Is there any news here?

        I made recently some changes to the UserInputPanelConsoleHelper eliminating the duplicate static String definitions and importing them from UserInputPanel, instead.

        From my point of view there are two different problems here:

        • missing support for some field types -> Is this still present from your point of view, can you review this with the latest snapshot? This should be done in IzPack 5.0
        • implementation cleanup -> This is still present as far as I can see, but can be moved to IzPack 5.0.x or 5.1.

        Let's move a bit with this issue, if you can

        Show
        Rene Krell added a comment - - edited Is there any news here? I made recently some changes to the UserInputPanelConsoleHelper eliminating the duplicate static String definitions and importing them from UserInputPanel, instead. From my point of view there are two different problems here: missing support for some field types -> Is this still present from your point of view, can you review this with the latest snapshot? This should be done in IzPack 5.0 implementation cleanup -> This is still present as far as I can see, but can be moved to IzPack 5.0.x or 5.1. Let's move a bit with this issue, if you can
        Hide
        Rene Krell added a comment -

        @Martin: Do you have a proposal for this? Can I help you somehow to get involved?
        @Tim: Is this branch ready to merge or is there some open work from your point of view?

        Show
        Rene Krell added a comment - @Martin: Do you have a proposal for this? Can I help you somehow to get involved? @Tim: Is this branch ready to merge or is there some open work from your point of view?
        Hide
        Tim Anderson added a comment -

        I've been refactoring UserInputPanel and friends at https://github.com/unb/izpack/tree/IZPACK-472 but I've been sidetracked with other projects.
        I probably won't get back to it until the new year. I'd say release 5.0.0-beta-11 without it.

        Show
        Tim Anderson added a comment - I've been refactoring UserInputPanel and friends at https://github.com/unb/izpack/tree/IZPACK-472 but I've been sidetracked with other projects. I probably won't get back to it until the new year. I'd say release 5.0.0-beta-11 without it.
        Hide
        Rene Krell added a comment -

        @Tim: Alright, thank you. You might need to merge the changes I made to not get in deeper conflicts as soon as you'll return to it. Your solution will be the more complete one I guess.

        Show
        Rene Krell added a comment - @Tim: Alright, thank you. You might need to merge the changes I made to not get in deeper conflicts as soon as you'll return to it. Your solution will be the more complete one I guess.
        Hide
        Tim Anderson added a comment -

        I've refactored UserInputPanel and UserInputPanelConsoleHelper and merged the corresponding pull request: https://github.com/izpack/izpack/pull/87 to master.
        The following field types are yet to be implemented:

        • multifile
        • search
        Show
        Tim Anderson added a comment - I've refactored UserInputPanel and UserInputPanelConsoleHelper and merged the corresponding pull request: https://github.com/izpack/izpack/pull/87 to master. The following field types are yet to be implemented: multifile search

          People

          • Assignee:
            Tim Anderson
            Reporter:
            Dennis Reil
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 3 days
              3d
              Remaining:
              Remaining Estimate - 3 days
              3d
              Logged:
              Time Spent - Not Specified
              Not Specified