IzPack

RefCondition is not resolve referenced condition

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.11.0
  • Fix Version/s: 4.0.0
  • Component/s: Compiler
  • Labels:
    None
  • Number of attachments :
    0

Description

Example below. CompilerConfig.addConditions collects conditions to local variable only, but RulesEngine.analyzeCondition() is looking for ref conditions using RulesEngine.getCondition(refid).
RulesEngine.getCondition(refid) use protected static RulesEngine.conditionsmap which is empty - so refconditions isn't resolved.

<conditions>
<condition type="packselection" id="sdkpackcondition">
<packid>sdk.pack</packid>
</condition>
<condition type="packselection" id="serverpackcondition">
<packid>server.pack</packid>
</condition>
<condition type="packselection" id="serverdbpackcondition">
<packid>server.db.pack</packid>
</condition>
<condition type="packselection" id="clientpackcondition">
<packid>client.pack</packid>
</condition>
<condition type="or" id="copycondition">
<condition type="or" id="copyconditionint">
<condition type="ref" refid="sdkpackcondition"/>
<condition type="ref" refid="serverpackcondition"/>
</condition>
<condition type="ref" refid="clientpackcondition"/>
</condition>
<condition type="or" id="processcondition">
<condition type="ref" refid="serverpackcondition"/>
<condition type="ref" refid="serverdbpackcondition"/>
</condition>
</conditions>

Activity

Hide
Julien Ponge added a comment -

I first assign this issue to Dennis, but he is free not to accept it

Show
Julien Ponge added a comment - I first assign this issue to Dennis, but he is free not to accept it
Hide
Dennis Reil added a comment -

Ok, I fixed the problem. The id of the referenced condition is now saved and the condition will try to get the referenced condition later on.

Show
Dennis Reil added a comment - Ok, I fixed the problem. The id of the referenced condition is now saved and the condition will try to get the referenced condition later on.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: