Issue Details (XML | Word | Printable)

Key: IZPACK-43
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Dennis Reil
Reporter: ashvedov
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
IzPack

RefCondition is not resolve referenced condition

Created: 26/Mar/08 08:55 AM   Updated: 01/Apr/08 06:59 AM   Resolved: 01/Apr/08 06:59 AM
Return to search
Component/s: Compiler
Affects Version/s: 3.11.0
Fix Version/s: 4.0.0

Time Tracking:
Not Specified


 Description  « Hide

Example below. CompilerConfig.addConditions collects conditions to local variable only, but RulesEngine.analyzeCondition() is looking for ref conditions using RulesEngine.getCondition(refid).
RulesEngine.getCondition(refid) use protected static RulesEngine.conditionsmap which is empty - so refconditions isn't resolved.

<conditions>
<condition type="packselection" id="sdkpackcondition">
<packid>sdk.pack</packid>
</condition>
<condition type="packselection" id="serverpackcondition">
<packid>server.pack</packid>
</condition>
<condition type="packselection" id="serverdbpackcondition">
<packid>server.db.pack</packid>
</condition>
<condition type="packselection" id="clientpackcondition">
<packid>client.pack</packid>
</condition>
<condition type="or" id="copycondition">
<condition type="or" id="copyconditionint">
<condition type="ref" refid="sdkpackcondition"/>
<condition type="ref" refid="serverpackcondition"/>
</condition>
<condition type="ref" refid="clientpackcondition"/>
</condition>
<condition type="or" id="processcondition">
<condition type="ref" refid="serverpackcondition"/>
<condition type="ref" refid="serverdbpackcondition"/>
</condition>
</conditions>



Julien Ponge added a comment - 27/Mar/08 05:51 PM

I first assign this issue to Dennis, but he is free not to accept it


Julien Ponge made changes - 27/Mar/08 05:51 PM
Field Original Value New Value
Assignee Dennis Reil [ dreil ]
Dennis Reil made changes - 31/Mar/08 01:29 AM
Status Open [ 1 ] In Progress [ 3 ]
Dennis Reil added a comment - 01/Apr/08 06:59 AM

Ok, I fixed the problem. The id of the referenced condition is now saved and the condition will try to get the referenced condition later on.


Dennis Reil made changes - 01/Apr/08 06:59 AM
Resolution Fixed [ 1 ]
Fix Version/s 4.0.0 [ 14071 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Dennis Reil made changes - 01/Apr/08 06:59 AM
Status Resolved [ 5 ] Closed [ 6 ]