IzPack

unistaller should look more like the installer

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 4.3.1
  • Fix Version/s: 5.0
  • Component/s: Uninstaller
  • Labels:
    None
  • Number of attachments :
    1

Description

The uninstaller currently looks very simple, but does not match the installer's design. It would be great to have a way to

  1. Make the uninstaller look like the installer
  2. Configure the panels shown in the uninstaller

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kjell Braden added a comment -

I've attached a larger set of changes. I've tried to keep the them as non-intrusive as possible. It probably supersedes more or less large parts of the code for the old uninstaller, but I don't have the overview of the code to decide what can be stripped.
I don't dare to commit this yet, therefore I'd like to hear other opinions first.

 bin/langpacks/installer/deu.xml                               |   10 
 bin/langpacks/installer/eng.xml                               |    9 
 src/build.xml                                                 |   74 +++-
 src/dist-files/IzPack-install.xml                             |    8 
 src/lib/com/izforge/izpack/compiler/Compiler.java             |    8 
 src/lib/com/izforge/izpack/compiler/CompilerConfig.java       |   32 +
 src/lib/com/izforge/izpack/compiler/IPackager.java            |    5 
 src/lib/com/izforge/izpack/compiler/MultiVolumePackager.java  |   63 +--
 src/lib/com/izforge/izpack/compiler/Packager.java             |   42 +-
 src/lib/com/izforge/izpack/compiler/PackagerBase.java         |   52 ++
 src/lib/com/izforge/izpack/compiler/PackagerHelper.java       |   56 ---
 src/lib/com/izforge/izpack/installer/UnpackerBase.java        |   74 +++-
 src/lib/com/izforge/izpack/panels/UninstallPanel.java         |  139 +++++++
 src/lib/com/izforge/izpack/panels/UninstallerFinishPanel.java |   92 ++++
 src/lib/com/izforge/izpack/panels/UninstallerHelloPanel.java  |  185 ++++++++++
 src/lib/com/izforge/izpack/rules/RulesEngine.java             |   13 
 src/lib/com/izforge/izpack/rules/StaticCondition.java         |   61 +++
 src/lib/com/izforge/izpack/uninstaller/Uninstaller.java       |   58 +--
 src/lib/com/izforge/izpack/util/IoHelper.java                 |   21 +
 19 files changed, 822 insertions(+), 180 deletions(-)
Show
Kjell Braden added a comment - I've attached a larger set of changes. I've tried to keep the them as non-intrusive as possible. It probably supersedes more or less large parts of the code for the old uninstaller, but I don't have the overview of the code to decide what can be stripped. I don't dare to commit this yet, therefore I'd like to hear other opinions first. bin/langpacks/installer/deu.xml | 10 bin/langpacks/installer/eng.xml | 9 src/build.xml | 74 +++- src/dist-files/IzPack-install.xml | 8 src/lib/com/izforge/izpack/compiler/Compiler.java | 8 src/lib/com/izforge/izpack/compiler/CompilerConfig.java | 32 + src/lib/com/izforge/izpack/compiler/IPackager.java | 5 src/lib/com/izforge/izpack/compiler/MultiVolumePackager.java | 63 +-- src/lib/com/izforge/izpack/compiler/Packager.java | 42 +- src/lib/com/izforge/izpack/compiler/PackagerBase.java | 52 ++ src/lib/com/izforge/izpack/compiler/PackagerHelper.java | 56 --- src/lib/com/izforge/izpack/installer/UnpackerBase.java | 74 +++- src/lib/com/izforge/izpack/panels/UninstallPanel.java | 139 +++++++ src/lib/com/izforge/izpack/panels/UninstallerFinishPanel.java | 92 ++++ src/lib/com/izforge/izpack/panels/UninstallerHelloPanel.java | 185 ++++++++++ src/lib/com/izforge/izpack/rules/RulesEngine.java | 13 src/lib/com/izforge/izpack/rules/StaticCondition.java | 61 +++ src/lib/com/izforge/izpack/uninstaller/Uninstaller.java | 58 +-- src/lib/com/izforge/izpack/util/IoHelper.java | 21 + 19 files changed, 822 insertions(+), 180 deletions(-)
Hide
Permalink
Tim Anderson added a comment -

Appologies, but this patch is now too far out of date to apply to 5.0.
Do you want to resubmit it for the current 5.0 codebase?

Show
Tim Anderson added a comment - Appologies, but this patch is now too far out of date to apply to 5.0. Do you want to resubmit it for the current 5.0 codebase?
Hide
Permalink
Daniel Abson added a comment -

Is anybody currently working on this?

Show
Daniel Abson added a comment - Is anybody currently working on this?
Hide
Permalink
Tim Anderson added a comment -

Not that I know of.

Show
Tim Anderson added a comment - Not that I know of.
Hide
Permalink
Rene Krell added a comment -

Please send a pull request at Github against the current 5.0 head with these changes.
Thank you

Show
Rene Krell added a comment - Please send a pull request at Github against the current 5.0 head with these changes. Thank you

People

  • Assignee:
    Kjell Braden
    Reporter:
    Kjell Braden
Vote (1)
Watch (5)

Dates

  • Created:
    Updated: