Variable substitution does not work for fileset and res elements

Christoph Panwinkler added a comment - 26/Jan/10 8:11 AM - edited also on Windows 7 with variables declared in install.xml e.g. <variables> ... <variable name="JAVA_VERSION" value="1.6.0_17" /> ... </variables> <pack name="Java Runtime" parent="Core" required="yes"> <fileset dir="jdk-${JAVA_VERSION}" targetdir="${INSTALL_PATH}\jdk"> .... </fileset> </pack>

Russell Bolles added a comment - 10/Feb/11 4:18 PM I found the problem in the source code. Not sure if I'm ready to become a contributor so I'm hoping someone who has their development environment set up will commit this change. com.izforge.izpack.compiler.CompilerConfig.java private void addPacksSingle(IXMLElement data) throws CompilerException Add the marked lines (sorry about the formatting loss): // We get the fileset list iter = el.getChildrenNamed("fileset").iterator(); while (iter.hasNext()) { IXMLElement f = iter.next(); String dir_attr = requireAttribute(f, "dir"); File dir = new File(dir_attr); if (!dir.isAbsolute()) { dir = new File(basedir, dir_attr); } //ADDITION***************************************************** if (!dir.exists()) { dir = new File(varsubst.substitute(dir.getAbsolutePath(), null)); // next existance checking appears in pack.addFile } //ADDITION***************************************************** if (!dir.isDirectory()) // also tests '.exists()' { parseError(f, "Invalid directory 'dir': " + dir_attr); }