IzPack
  1. IzPack
  2. IZPACK-391

hidden="true" for Packs does not work for TreePacksPanel

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.3.4, 5.0
    • Component/s: Installer
    • Labels:
      None
    • Environment:
      All
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      I am trying to use hidden="true" attribute for pack definitions. It works fine if I display the packs in regular Packs Panel, but it throws exception if I use TreePacksPanel.

        Activity

        Hide
        Katarzyna Czeczot added a comment -

        this fixes it for me, I haven't tested it a lot though

        Show
        Katarzyna Czeczot added a comment - this fixes it for me, I haven't tested it a lot though
        Hide
        Katarzyna Czeczot added a comment -
        Show
        Katarzyna Czeczot added a comment - duplicate with http://jira.codehaus.org/browse/IZPACK-461
        Hide
        Julien Ponge added a comment -

        This does not apply on master.

        Show
        Julien Ponge added a comment - This does not apply on master.
        Hide
        Julien Ponge added a comment -

        I am closing the issue. It does not do what is advertised, as it introduces a new attribute doNotShowPackSize as a side-effect.

        Show
        Julien Ponge added a comment - I am closing the issue. It does not do what is advertised, as it introduces a new attribute doNotShowPackSize as a side-effect.
        Hide
        Katarzyna Czeczot added a comment -

        It does what is advertised

        doNotShowPackSize is not new attribute, it was used in table view already so it's merely unifing the interfaces

        I added it here because I didn't want to fix the size bug in the tree packs panel as I didn't need it

        I attached the patch only as a way of helping people who have the same problem as I did.

        Show
        Katarzyna Czeczot added a comment - It does what is advertised doNotShowPackSize is not new attribute, it was used in table view already so it's merely unifing the interfaces I added it here because I didn't want to fix the size bug in the tree packs panel as I didn't need it I attached the patch only as a way of helping people who have the same problem as I did.
        Hide
        Julien Ponge added a comment -

        Let me check then...

        Show
        Julien Ponge added a comment - Let me check then...
        Hide
        Julien Ponge added a comment -

        Ok, my bad

        It's in, thanks.

        Show
        Julien Ponge added a comment - Ok, my bad It's in, thanks.

          People

          • Assignee:
            Julien Ponge
            Reporter:
            Vikash Kumar
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: