Issue Details (XML | Word | Printable)

Key: IZPACK-35
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Julien Ponge
Reporter: Ansgar Konermann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
IzPack

Error message if configuration file not readable can be misleading

Created: 21/Mar/08 05:45 PM   Updated: 22/Mar/08 01:03 PM   Resolved: 22/Mar/08 01:03 PM
Return to search
Component/s: Compiler
Affects Version/s: 3.11.0
Fix Version/s: 4.0.0

Time Tracking:
Original Estimate: 2 hours
Original Estimate - 2 hours
Remaining Estimate: 2 hours
Remaining Estimate - 2 hours
Time Spent: Not Specified
Time Spent - Not Specified

File Attachments: 1. File CompilerConfig.diff (2 kB)
Environment: Slackware Linux 12.0, Sun Java 1.6.0_04

Patch Submitted: Yes


 Description  « Hide

In CompilerConfiguration.java (line 1735), the code checks whether the configuration file is readable. The error message specified here is somewhat misleading sometimes. It just says "invalid file". If you're new to IzPack and don't know the reason for this message, "invalid file" could also be interpreted as "contains invalid content", meaning "syntactically wrong".

It would be nice if the error messages were mere distinguished.

Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Ansgar Konermann added a comment - 21/Mar/08 05:46 PM

Affects 3.11.0, Compiler


[ Permalink | « Hide ]
Ansgar Konermann added a comment - 21/Mar/08 05:53 PM

Patch should give an idea how this could be improved.

However, it needs to be quality-checked: I was unable to build complete project using ant due to time constraints.


Ansgar Konermann made changes - 21/Mar/08 05:53 PM
Field Original Value New Value
Attachment CompilerConfig.diff [ 33371 ]
[ Permalink | « Hide ]
Ansgar Konermann added a comment - 21/Mar/08 05:56 PM

Priority should probably be lowered. Unfortunately, I'm unable to edit this issue anymore.


[ Permalink | « Hide ]
Julien Ponge added a comment - 22/Mar/08 05:52 AM

Thanks for the report, I will handle it in the next few days.


Julien Ponge made changes - 22/Mar/08 05:52 AM
Assignee Julien Ponge [ jponge ]
Affects Version/s 3.11.0 [ 14089 ]
Fix Version/s 4.0.0 [ 14071 ]
Component/s Compiler [ 13124 ]
Patch Submitted [Yes]
Julien Ponge made changes - 22/Mar/08 05:59 AM
Priority Major [ 3 ] Minor [ 4 ]
Julien Ponge made changes - 22/Mar/08 12:47 PM
Status Open [ 1 ] In Progress [ 3 ]
Julien Ponge made changes - 22/Mar/08 01:02 PM
Status In Progress [ 3 ] Open [ 1 ]
[ Permalink | « Hide ]
Julien Ponge added a comment - 22/Mar/08 01:03 PM

Thanks for the patch, it has been applied with minor changes.


Julien Ponge made changes - 22/Mar/08 01:03 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Julien Ponge made changes - 22/Mar/08 01:03 PM
Status Resolved [ 5 ] Closed [ 6 ]
Atlassian JIRA (v4.0#466) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.