|
Sort Order:
Florian Buehlmann made changes - 27/Feb/09 01:53 AM
Florian Buehlmann made changes - 27/Feb/09 05:07 AM
Florian Buehlmann made changes - 27/Feb/09 05:08 AM
Florian, I run into this problem with Windows UNC paths with IzPack 4.2.1 and I started to write a patch before I saw your Jira entry and your patch. I don't like how the special case of Windows UNC paths are handled in your patch. I have developed 3 alternative patches. Please have a look at them. Patch 1 makes minimal changes to the original code by using the URI class instead of the URL class. Patch 2 is an improvement to patch 1, to avoid creating a File object that contains a "!" within the path and a last path component ("info") within the JAR file. This could be a problem in some operating systems or in future or alternative Java implementations. Patch 3 uses getProtectionDomain() instead of getResource() to find the path of the JAR file. This has the advantage of not having to extract the nested "file:" URL out of the outer "jar:" URL. All three alternative patches don't need extra code to handle Windows UNC paths and should be more portable and future-proof than the current solution.
Christian d'Heureuse made changes - 22/Mar/09 05:19 PM
Related: Christian thanks for the patch. Your solution is really better than mine. I change the code to be more flexible for the future.
Julien Ponge made changes - 20/Apr/09 03:26 AM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Closed
Critical
Loose pack do not work if installation is startet from UNC path
Loose packs are now working if the installation is started from a UNC path.