IzPack

Possible execution of a java class before and after a panel

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 4.2.0
  • Fix Version/s: 4.3.0
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

It were very useful to add the possibility to run a specific java class befora a panel activates, before the panel validates and after the panel validation.
This could be done with an additional tag in the panel tag like the following:

<panel classname="UserInputPanel" id="my.panel.id" >
<validator classname="PanelValidator"/>
<actions>
<action stage="preactivate" classname="PreActivateAction" />
<action stage="prevalidate" classname="PreValidationAction" />
<action stage="postvalidate" classname="PostValidationAction" />
</actions>
</panel>

There is no possibility to pass parameters but in the action the user has access to AutomatedInstallData by passing it as a paramter into the action.

Issue Links

Activity

Hide
Julien Ponge added a comment -

Nice.

You should discuss this on the dev list.

Show
Julien Ponge added a comment - Nice. You should discuss this on the dev list.
Hide
Florian Buehlmann added a comment -

There is an additional action that is called before the constructor of the panel.
<action stage="preconstruct" classname="PreConstructionAction" />

Show
Florian Buehlmann added a comment - There is an additional action that is called before the constructor of the panel. <action stage="preconstruct" classname="PreConstructionAction" />
Hide
Julien Ponge added a comment -

Dennis, I think Florian is already working on it, or am I missing something?

Show
Julien Ponge added a comment - Dennis, I think Florian is already working on it, or am I missing something?
Hide
Florian Buehlmann added a comment -

I'm nearly finish. Just writing the documentation. Ready for checkin tomorrow.
=> Reassign to me

Show
Florian Buehlmann added a comment - I'm nearly finish. Just writing the documentation. Ready for checkin tomorrow. => Reassign to me
Hide
Dennis Reil added a comment -

ok...

Show
Dennis Reil added a comment - ok...
Hide
Florian Buehlmann added a comment -

I would like to patch this back to 4.2.1 that I can use the 4.2.1 distribution for my own installers.
Is it possible to patch this back?

Show
Florian Buehlmann added a comment - I would like to patch this back to 4.2.1 that I can use the 4.2.1 distribution for my own installers. Is it possible to patch this back?
Hide
Julien Ponge added a comment -

Hi Florian,

This is really a new feature, so it should not go into 4.2.1. (I know it is less convenient for you, but that is really better not to mix everything)

I guess that meanwhile you can easily apply the patch on top of 4.2.1.

Cheers

Show
Julien Ponge added a comment - Hi Florian, This is really a new feature, so it should not go into 4.2.1. (I know it is less convenient for you, but that is really better not to mix everything) I guess that meanwhile you can easily apply the patch on top of 4.2.1. Cheers
Hide
Florian Buehlmann added a comment - - edited

Bug is marked as enhancement, but I agree with you

Show
Florian Buehlmann added a comment - - edited Bug is marked as enhancement, but I agree with you
Hide
Florian Buehlmann added a comment -

PanelActions are now available and documented.

Show
Florian Buehlmann added a comment - PanelActions are now available and documented.
Hide
Florian Buehlmann added a comment -

The actions are not working on automated installation

Show
Florian Buehlmann added a comment - The actions are not working on automated installation
Hide
Florian Buehlmann added a comment -

Actions are now called during automated installation also.

Show
Florian Buehlmann added a comment - Actions are now called during automated installation also.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: