Issue Details (XML | Word | Printable)

Key: IZPACK-285
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Florian Buehlmann
Reporter: Florian Buehlmann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
IzPack

Possible execution of a java class before and after a panel

Created: 11/Feb/09 04:49 AM   Updated: 20/Apr/09 03:26 AM   Resolved: 13/Feb/09 08:36 AM
Return to search
Component/s: None
Affects Version/s: 4.2.0
Fix Version/s: 4.3.0

Time Tracking:
Not Specified

Issue Links:
dependent
 


 Description  « Hide

It were very useful to add the possibility to run a specific java class befora a panel activates, before the panel validates and after the panel validation.
This could be done with an additional tag in the panel tag like the following:

<panel classname="UserInputPanel" id="my.panel.id" >
<validator classname="PanelValidator"/>
<actions>
<action stage="preactivate" classname="PreActivateAction" />
<action stage="prevalidate" classname="PreValidationAction" />
<action stage="postvalidate" classname="PostValidationAction" />
</actions>
</panel>

There is no possibility to pass parameters but in the action the user has access to AutomatedInstallData by passing it as a paramter into the action.



Julien Ponge added a comment - 11/Feb/09 06:29 AM

Nice.

You should discuss this on the dev list.


Florian Buehlmann added a comment - 12/Feb/09 04:48 AM

There is an additional action that is called before the constructor of the panel.
<action stage="preconstruct" classname="PreConstructionAction" />


Julien Ponge added a comment - 12/Feb/09 07:26 AM

Dennis, I think Florian is already working on it, or am I missing something?


Florian Buehlmann added a comment - 12/Feb/09 08:16 AM

I'm nearly finish. Just writing the documentation. Ready for checkin tomorrow.
=> Reassign to me


Dennis Reil added a comment - 13/Feb/09 02:07 AM

ok...


Florian Buehlmann added a comment - 13/Feb/09 02:24 AM

I would like to patch this back to 4.2.1 that I can use the 4.2.1 distribution for my own installers.
Is it possible to patch this back?


Julien Ponge added a comment - 13/Feb/09 02:36 AM

Hi Florian,

This is really a new feature, so it should not go into 4.2.1. (I know it is less convenient for you, but that is really better not to mix everything)

I guess that meanwhile you can easily apply the patch on top of 4.2.1.

Cheers


Florian Buehlmann added a comment - 13/Feb/09 02:50 AM - edited

Bug is marked as enhancement, but I agree with you


Florian Buehlmann added a comment - 13/Feb/09 02:51 AM

PanelActions are now available and documented.


Florian Buehlmann added a comment - 13/Feb/09 07:40 AM

The actions are not working on automated installation


Florian Buehlmann added a comment - 13/Feb/09 08:36 AM

Actions are now called during automated installation also.